Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1627 Add Keras #1793

Merged
merged 3 commits into from Oct 28, 2019
Merged

#1627 Add Keras #1793

merged 3 commits into from Oct 28, 2019

Conversation

louis993546
Copy link
Contributor

Issue: #1627

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Oct 19, 2019
@birjj
Copy link
Contributor

birjj commented Oct 19, 2019

@louistsaitszho Can you please elaborate a bit on where you got the SVG from? I can't seem to find an actual vector on https://keras.io/

@birjj birjj added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Oct 19, 2019
@louis993546
Copy link
Contributor Author

@birjolaxew In the issue itself (#1627), it included a link to the svg directly.

@birjj
Copy link
Contributor

birjj commented Oct 22, 2019

@louistsaitszho In that case the source should definitely be the ml-logos repository. That being said, it looks like this vectorization is not particularly accurate when compared to the official raster logo:

I have been unable to find a proper vectorization of their logo anywhere, so I think we would want a manual vectorization based on the official raster logo instead. If you want to take on that challenge feel free @louistsaitszho - otherwise we might want to close this PR to signal to others that it's up for grabs. I'll let you make the decision.

@birjj birjj added changes requested and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Oct 22, 2019
@louis993546
Copy link
Contributor Author

@birjolaxew hmmm I should have checked that. Let me try it out this week, and I will provide either an update to this PR, or close this PR, by the end of this week.

@louis993546
Copy link
Contributor Author

ezgif com-video-to-gif

Ok re-created that. Does it look ok now?

@birjj
Copy link
Contributor

birjj commented Oct 28, 2019

👍 That looks great @louistsaitszho, thanks a lot for your work on this PR!

@birjj birjj merged commit 0e90fc4 into simple-icons:develop Oct 28, 2019
@birjj birjj mentioned this pull request Nov 3, 2019
Merged
@NovaGL NovaGL mentioned this pull request Aug 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birjj birjj birjj approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louis993546 @birjj @ericcornelissen