Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Apache NetBeans (#1563) #1885

Merged
merged 4 commits into from
Nov 14, 2019
Merged

Add Apache NetBeans (#1563) #1885

merged 4 commits into from
Nov 14, 2019

Conversation

phatbhoy67
Copy link
Contributor

Issue: #1563

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Removed colour, added stroke and resized official logo .svg.

Suggested hex value #1B6AC6 present in logo and on website.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Nov 5, 2019
ericcornelissen
ericcornelissen suggested changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we merge this in I would like to discuss the following two points with other @simple-icons/maintainers, besides that I have a small suggestion to change the name to "Apache NetBeans IDE" (which would require you to change the filename of the SVG).

_data/simple-icons.json Outdated Show resolved Hide resolved
@phatbhoy67
Copy link
Contributor Author

phatbhoy67 commented Nov 5, 2019 •
edited

First on left is current stroke for comparison.

apache-netbeans-stroke

phatbhoy67 and others added 2 commits November 6, 2019 01:03
@phatbhoy67 @ericcornelissen
Update _data/simple-icons.json
2e1a0fa 
Co-Authored-By: Eric Cornelissen <ericornelissen@gmail.com>
@phatbhoy67
Updates title and renamed svg
aec128d
ericcornelissen
ericcornelissen approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but again I will leave it to another maintainer to merge this in.

@ericcornelissen ericcornelissen added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Nov 9, 2019
@birjj birjj merged commit 28baca2 into simple-icons:develop Nov 14, 2019
@ericcornelissen ericcornelissen removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Nov 14, 2019
@phatbhoy67 phatbhoy67 deleted the apache-netbeans branch November 16, 2019 16:34
@ericcornelissen ericcornelissen mentioned this pull request Nov 25, 2019
Merged
birjj added a commit that referenced this pull request Nov 25, 2019
@birjj
Publish version 1.20.0
a26b15e 
New icons:

- AlliedModders (#1893)
- Bitrise (#1829)
- Khan Academy (#1884)
- C# (#1807)
- Mapbox (#1897)
- Monster (#1892)
- MicroStrategy (#1899)
- Pastebin (#1887)
- strongSwan (#1906)
- ABB RobotStudio (#1886)
- Asciidoctor (#1886)
- Source Engine (#1898)
- Valve (#1907)
- Steamworks (#1908)
- Apache NetBeans IDE (#1885)
- Beats by Dre (#1924)
- MDN Web Docs (#1925)
- Algolia (#1929)
- CodeChef (#1921)
- Minds (#1917)
- Duolingo ( #1922, 5388f8d)
- ManageIQ (#1926)
- ReactOS (#1941)
- IPFS (#1949)
- PureScript (#1910)
- PyUp (#1954)
- QEMU (#1957)
- Prometheus (#1964)
- Timescale (#1962)
- awesomeWM (#1966)
- Anchor (#1960)
- Zhihu (#1959)
- Google Search Console (#1947)
- InfluxDB (#1965)
- Apache OpenOffice (#1976)

Updated icons:

- Houzz (#1928)
- Vue.js (#1979)
@beatrizsmerino
Copy link

image
image

Hi!! this not working. I am using the icon for the https://shields.io/ and it is not visible, the width of the line is too thin.

@ericcornelissen ericcornelissen mentioned this pull request Oct 11, 2020
Closed
@ericcornelissen
Copy link
Contributor

Thanks for pointing this out @beatrizsmerino. It seems like a legitimate problem (I recall that around the time of this icon we discussed a minimum width for lines in icons that are an artistic interpretation). I created a new issue for this problem.

@phatbhoy67, do you happen to have the alternative versions laying around somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcornelissen ericcornelissen ericcornelissen approved these changes

@birjj birjj Awaiting requested review from birjj

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phatbhoy67 @beatrizsmerino @ericcornelissen @birjj