Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Volkswagen #2150

Merged
merged 5 commits into from Dec 20, 2019
Merged

Add Volkswagen #2150

merged 5 commits into from Dec 20, 2019

Conversation

PeterShaggyNoble
Copy link
Member

Volkswagen
Issue: #2059

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon was found in the source of https://www.volkswagen.ie/. Colour #001e50 was taken from the stylesheet of https://www.volkswagen-newsroom.com/ but other options could be #151f5d (used in this image) and #1d1f20 (Found in the same location as the icon).

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Dec 17, 2019
@PeterShaggyNoble
Copy link
Member Author

I should have pointed out that the image I lifted the #151f5d colour from was found in this press release about their rebranding.

runxel
runxel approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
I am not fully convinced however with the color. But because VW themself is not consistent.... we shouldn't stress it too much maybe.
Still: I'm a tiny bit more in favor of #151f5d 😅

Wikimedia has completely different color btw.

@PeterShaggyNoble
Copy link
Member Author

PeterShaggyNoble commented Dec 19, 2019 •
edited

Thanks, @runxel. I think I agree with you on that colour choice purely based on them using it in a splash image announcing their new branding. Let's see what the other @simple-icons/maintainers think, though, before I update it.

@birjj
Copy link
Contributor

birjj commented Dec 20, 2019

Ye I think I agree with #151f5d. Once you've updated that you can go ahead and merge @PeterShaggyNoble - everything else looks good to me!

@PeterShaggyNoble
Copy link
Member Author

Thanks, @birjolaxew. Colour updated; will merge once checks have completed.

@PeterShaggyNoble PeterShaggyNoble merged commit 7b80ebc into simple-icons:develop Dec 20, 2019
@PeterShaggyNoble PeterShaggyNoble deleted the volkswagen branch December 20, 2019 09:37
@ericcornelissen ericcornelissen mentioned this pull request Dec 23, 2019
Merged
birjj added a commit that referenced this pull request Dec 24, 2019
@birjj
Release 47 new icons and 3 updated icons (v2.1.0)
e16c9d9 
New icons:

- Dart (#2106)
- Audi (#2065)
- Pi-hole (#2084)
- Fijutsu (#2076)
- Uber Eats (#2078)
- RocketMQ (#2112)
- ZeroMQ (#2115)
- Cordova (#2027)
- XMPP (#2085)
- V (#2056)
- Cryengine (#2079)
- Mercedes (#2114)
- Corona Renderer (#2129)
- Fujifilm (#2131)
- Parse.ly (#2138)
- Nutanix (#2098)
- Publons (#2130)
- Webmin (#2132)
- X.Org (#2122)
- Notist (#2123)
- Directus (#2142)
- DLNA (#2080)
- Ember.js (#2143)
- Waze (#2146)
- StackPath (#2145)
- Jinja (#2144)
- Floatplane (#2140)
- Box (#2159)
- WhiteSource (#2121)
- Vodafone (#2096)
- WebAuthn (#2104)
- Xamarin (#2176)
- Dunked (#2178)
- Stencyl (#2184)
- Zend (#2171)
- Zend Framework (#2171)
- OpenSSL (#2043)
- Crehana (#2045)
- Lufthansa (#2113)
- iOS (#2147)
- Broadcom (#2163)
- Volkswagen (#2150)
- GNOME (#2177)
- cPanel (#2173)
- Coinbase (#1845)
- Sketch (#2208)
- ICON (#2165)

Updated icons

- Node.js (#2134)
- Meetup (#2062)
- GitLab (#2192)
@runxel runxel mentioned this pull request Mar 6, 2020
Closed
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runxel runxel runxel approved these changes

@birjj birjj birjj approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PeterShaggyNoble @birjj @runxel @ericcornelissen