Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VOX #2205

Merged
merged 7 commits into from Jan 13, 2021
Merged

Add VOX #2205

merged 7 commits into from Jan 13, 2021

Conversation

vigonotion
Copy link
Contributor

Issue:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Color was extracted from primary color of their website (https://www.vox.de/)

@foo-dogsquared
Copy link
Contributor

Alexa ranking: ~61k

Take note there is a similar site called Vox that tackles on news/opinions and it seems to be unrelated with each other based on my quick search here.
Can you confirm this, @vigonotion ?

@vigonotion
Copy link
Contributor Author

Yes, they are completely unrelated. They are written differently though (VOX and Vox).

Shall I add some kind of suffix? But there is no official suffix (like TV or DE).

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Dec 23, 2019
@foo-dogsquared
Copy link
Contributor

Personally, I would go with the suffix 'TV' (making it 'VOX TV').
Though, my input is not enough.

I'll wait for the other @simple-icons/maintainers to see their take on this.

@PeterShaggyNoble
Copy link
Member

I think we should go ahead and add this one as just "VOX". We're a fair few icons deep on this project without (as far as I can see) having had any clashes in brand names.

If and when the time comes that such a clash does arise, we can address it then.

Of course, Sod's Law dictates that, now that I've said that, someone's going to immediately request a vox.com icon!

@ericcornelissen ericcornelissen mentioned this pull request Jan 2, 2020
Closed
7 tasks
@ericcornelissen
Copy link
Contributor

I don't think it is unlikely the vox.com icon will be requested and ideally we deal with name clashes before that happens, as it will likely result in backwards compatibility issues 😞 That said, I'm really not sure how we would do that. I opened #2260 to discuss this further. In the meanwhile I will mark this with "Awaiting replay" and I don't think we should merge this in until we found a suitable solution.

@ericcornelissen ericcornelissen added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed in discussion There is an ongoing discussion that should be finished before we can continue and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Jan 2, 2020
@runxel runxel added the pending Issues that are pending because of e.g. a scheduled brand update label Jan 21, 2020
@ericcornelissen ericcornelissen removed the in discussion There is an ongoing discussion that should be finished before we can continue label Feb 24, 2020
@runxel runxel added this to the v3.0.0 milestone Mar 14, 2020
@PeterShaggyNoble
Copy link
Member

Coming back to this one again, I don't think that #2260 should block us merging it as I think whatever we do do avoid name clashes should be done on a "first come, first served" basis, as best we can. For example, should the other Vox ever be added, we could quite easily solve the problem in this case by calling that one "Vox.com". Thoughts, @simple-icons/maintainers?

@PeterShaggyNoble
Copy link
Member

As there have been no objections, I'm going to invoke the "first-come, first-served" rule here and finally get around to reviewing this one! 😆

Taking the source SVG as-is, there are quite a few differences between your version (in green below) and it, @vigonotion - could you look into those, please?

Also, since this PR was opened, we have changed our requirements for source URLs from Wikpedia & Wikimedia; they should now link to the file's page rather than the brands so could you update the URL in your JSON to https://commons.wikimedia.org/wiki/File:VOX_Logo_2013.svg?

@PeterShaggyNoble PeterShaggyNoble added changes requested and removed pending Issues that are pending because of e.g. a scheduled brand update labels Jun 11, 2020
@PeterShaggyNoble PeterShaggyNoble removed this from the v3.0.0 milestone Jun 11, 2020
@vigonotion
Copy link
Contributor Author

I used the 1993 logo, because it was already (almost) monochrome. But if desired, I redo the icon based on the current logo

@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Jun 11, 2020 •
edited

Yeah, I thinkwe should go with the latest version. Warning, though: That SVG is a mess of multiple paths and there is an <image> tag sitting on top of the <path> tags of the circle that is slightly larger than the paths underneath.

Before you go to the effort, though, you could try doing a visual comparison between your version and the logo from their website as, just by eyeballing it, the circle does appear to be slightly smaller there than in the latest version on Wikimedia.

Alternatively, this version can be found in the HTML of their site: https://www.vox.de/safari-pinned-tab.svg It's very poorly Potraced but it might be easier to clean it up than to work with the Wikimedia file.

@PeterShaggyNoble
Copy link
Member

Are you still working on this one, @vigonotion?

@vigonotion
Copy link
Contributor Author

Didn't have the time yet, gonna look at this again this weekend as this is probably not a big change

@vigonotion
Copy link
Contributor Author

Sorry it took me so long, but here it is. I used the 2013 logo svg and drew a circle above that red ball (which was an image in the original svg). I eyeballed it, as the circle wasn't even a round circle, but I think this really is good enough.

@ericcornelissen
Copy link
Contributor

The SVG looks good now, unfortunately the size of the logo is just slightly off (possibly due to optimization). Could you look into this and fix that?

@adamrusted
Copy link
Member

The SVG looks good now, unfortunately the size of the logo is just slightly off (possibly due to optimization). Could you look into this and fix that?

vox

Just chipping in with a path that is passing the linter.

M24 15.802h-4.129l-1.42-1.754-1.564 1.754H14.12l.103-.05a4.242 4.242 0 0 0 .262-.145c.054-.033.107-.068.161-.103.034-.022.067-.043.1-.066.033-.023.064-.048.096-.072a6.536 6.536 0 0 0 .264-.214 6.058 6.058 0 0 0 .355-.351 3.76 3.76 0 0 0 .223-.269 6.266 6.266 0 0 0 .154-.217 3.108 3.108 0 0 0 .155-.252 4.921 4.921 0 0 0 .221-.447l.055-.135a4.016 4.016 0 0 0 .103-.303 3.019 3.019 0 0 0 .07-.267 3.815 3.815 0 0 0 .058-.309c.008-.05.014-.1.02-.149.006-.047.01-.094.014-.141a4.695 4.695 0 0 0 .016-.267c.001-.053-.002-.106-.002-.16-.001-.053 0-.106-.002-.16l-.006-.081a82.085 82.085 0 0 0-.022-.238l-.012-.089-.014-.093a4.162 4.162 0 0 0-.074-.353l-.024-.091-.036-.122a2.957 2.957 0 0 0-.089-.255 9.635 9.635 0 0 0-.061-.152c-.012-.028-.023-.057-.036-.085-.017-.038-.037-.076-.056-.113-.03-.06-.059-.119-.091-.178a3.958 3.958 0 0 0-.329-.508 4.357 4.357 0 0 0-.174-.216c-.039-.046-.08-.09-.121-.135a1.682 1.682 0 0 0-.148-.15c-.046-.043-.091-.086-.138-.128a5.26 5.26 0 0 0-.355-.282c-.031-.022-.063-.042-.095-.063-.032-.021-.063-.043-.095-.063l-.089-.053c-.036-.022-.072-.044-.109-.064l-.026-.014h3.185l.931 1.248.952-1.248h4.173l-3.088 3.572L24 15.802zM10.205 8.198H7.112l-1.678 3.216-1.705-3.216H0l4.182 7.603h2.442l1.527-2.732-.025-.084c-.013-.047-.023-.095-.033-.142a5.524 5.524 0 0 1-.049-.272c-.008-.052-.014-.105-.02-.158l-.015-.156c-.002-.026-.005-.052-.006-.079-.003-.054-.002-.11-.002-.166-.001-.056-.004-.112-.003-.168l.005-.095c.003-.055.006-.11.011-.166a2.52 2.52 0 0 1 .012-.125l.016-.127.026-.162a4.078 4.078 0 0 1 .062-.285l.04-.147.05-.16.044-.127.036-.095.048-.115c.014-.033.028-.066.044-.099.02-.043.041-.085.063-.127l.058-.111.023-.042.029-.053.035-.059.049-.079.067-.103.073-.105.066-.09a6.9 6.9 0 0 1 .069-.089l.071-.087.079-.091c.036-.041.073-.08.11-.12l.064-.067c.029-.029.06-.056.09-.084a6.042 6.042 0 0 1 .265-.232 3.47 3.47 0 0 1 .119-.093c.041-.031.082-.06.124-.09.039-.028.079-.054.119-.081l.108-.068c.028-.017.056-.036.086-.051.015-.008.046-.02.046-.021zm2.075 1.59a2.132 2.132 0 1 0 0 4.264 2.132 2.132 0 0 0 0-4.264z

If another @simple-icons/maintainers can okay this path, then feel free to use it 😁

@PeterShaggyNoble
Copy link
Member

Man, I can't believe this one's still going, over a year later 😆

@adamrusted, in the interests of getting this off our plate (and finally giving @vigonotion some peace!), I don't think anyone would object to you pushing your version directly to the branch and we'll take it from there.

@adamrusted
Copy link
Member

@PeterShaggyNoble sorted - if another @simple-icons/maintainers could take a look at this, we may be able to finally get it merged!

@vigonotion
Copy link
Contributor Author

Thaaaank you @adamrusted, that thing was a journey 😄

@fbernhart
Copy link
Contributor

@adamrusted I can see a slight difference between your version (red) and the source (black). Probably due to optimizing it and the circle only having two points.
image

On the other hand, the V and X have A LOT of points, that probably aren't really needed. Would be worth it simplifying it a bit in my opinion.

image

I've created a simplified path (with a precision of 3) that should still match perfectly the source, while it only has 1/4 of file size.

<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>VOX icon</title><path d="M0 8.198l4.182 7.604h2.442L8.15 13.07a4.276 4.276 0 0 1 2.054-4.872H7.112l-1.677 3.216-1.706-3.216zm14.342 0a4.24 4.24 0 0 1 1.923 2.206c.784 2.081-.098 4.415-2.145 5.398h2.767l1.564-1.754 1.42 1.754H24l-3.505-4.032 3.088-3.572H19.41l-.952 1.249-.931-1.249zm-2.09 1.596c-.949 0-1.913.69-2.074 1.775a2.132 2.132 0 0 0 2.064 2.483c1.268.01 2.192-1.126 2.156-2.18-.013-1.015-.877-2.08-2.146-2.078z"/></svg>

Could you review it and if it matches the source push it and merge it? 😊

adamrusted
adamrusted approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot on @fbernhart!
Thanks @vigonotion for the work on the original PR, hopefully now you can rest easy at night! 😆

EDIT: would help if I pushed the new SVG before trying to merge it, wouldn't it?

@fbernhart
Update to @fbernhart's path.
005cc1f 
Co-Authored-By: Florian Bernhart <70264417+fbernhart@users.noreply.github.com>
@adamrusted adamrusted merged commit 1de1fd7 into simple-icons:develop Jan 13, 2021
@github-actions github-actions bot mentioned this pull request Jan 17, 2021
Merged
ericcornelissen added a commit that referenced this pull request Jan 17, 2021
@ericcornelissen
Release 47 new icons and 11 updated icons (v4.7.0)
1b97d4a 
# New Icons

- Acer (#4680)
- AliExpress (#4712)
- Bank of America (#4722)
- Blazor (#4694)
- Blueprint (#4729)
- CodeceptJS (#3399)
- Codemagic (#4711)
- Cucumber (#4754)
- Deutsche Bahn (#4210)
- Devpost (#4771)
- Espressif (#4720)
- Flipkart (#4734)
- Folium (#4688)
- FutureLearn (#4773)
- Game Jolt (#4742)
- Git LFS (#4737)
- Google Optimize (#4785)
- Graylog (#4675)
- Headspace (#4765)
- Home Assistant Community Store (#4755)
- Hotjar (#4723)
- Jellyfin (#4674)
- Kali Linux (#4768)
- Less (#4693)
- Metro (#3183)
- Momenteo (#4676)
- NBA (#4739)
- New Japan Pro-Wrestling (#2791)
- OWASP (#4783)
- Pioneer DJ (#4709)
- PlayStation 5 (#4641)
- Postmates (#4781)
- Presto (#4623)
- QuickBooks (#4782)
- Rolls-Royce (#4772)
- Rotten Tomatoes (#4770)
- Selenium (#4769)
- Semantic UI React (#4743)
- Southwest Airlines (#2896)
- Taobao (#4632)
- The Irish Times (#4752)
- TP-Link (#4732)
- Unacademy (#4689)
- VOX (#2205)
- WALKMAN (#4670)
- Wikidata (#4738)
- Yale (#4721)

# Updated Icons

- Accusoft (#3751)
- Citrix (#4748)
- Ferrari (#4778)
- General Motors (#4741)
- Google Chat (#4695, #4736)
- Intel (#4751)
- Kahoot! (#4731)
- Kia (#4730)
- Microsoft (#4649)
- Visa (#4719)
- Webflow (#4715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

@ericcornelissen ericcornelissen ericcornelissen approved these changes

@fbernhart fbernhart Awaiting requested review from fbernhart

@PeterShaggyNoble PeterShaggyNoble Awaiting requested review from PeterShaggyNoble

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vigonotion @foo-dogsquared @PeterShaggyNoble @ericcornelissen @adamrusted @fbernhart @runxel