Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Peugeot #2515

Merged
merged 1 commit into from Feb 2, 2020
Merged

Add Peugeot #2515

merged 1 commit into from Feb 2, 2020

Conversation

runxel
Copy link
Member

@runxel runxel commented Feb 1, 2020

Issue:
#2059

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Color was taken from wordmark in official SVG.

see simple-icons#2059
Color was taken from wordmark in official SVG.
@runxel runxel added the new icon Issues or pull requests for adding a new icon label Feb 1, 2020
@phatbhoy67
Copy link
Contributor

Nice work @runxel 👍

@phatbhoy67 phatbhoy67 merged commit e7166be into simple-icons:develop Feb 2, 2020
@runxel runxel deleted the psa2 branch February 2, 2020 23:32
@PeterShaggyNoble
Copy link
Member

Should the eye not be knocked out of this? And I wonder would an outline be a better treatment? 🤔

@runxel
Copy link
Member Author

runxel commented Feb 4, 2020

Should the eye not be knocked out of this? And I wonder would an outline be a better treatment?

No and no.
Brief explanation:

  • The eye isn't even knocked out in the original version, it's just a small black dot.
  • Also at small sizes nobody can actually see it.
  • An outline would look weird here, because the icon is not uniform enough (think of the tail...!).

@ericcornelissen
Copy link
Contributor

The eye isn't even knocked out in the original version, it's just a small black dot.
Also at small sizes nobody can actually see it.

That, to me, doesn't sound like we shouldn't cut it out. Though it is an artistic interpretation, I do think it would make the logo more recognizable 🤔

An outline would look weird here, because the icon is not uniform enough (think of the tail...!).

Although I agree a filled version is more accurate, I don't think a outlined version would look weird. (in fact, an older version of the logo is an outline!)

@runxel
Copy link
Member Author

runxel commented Feb 4, 2020

The outline works, if it's the same size as the tail, otherwise the tail would either look to big or to small.
Anyway, if I have time I will make a version with eyes for you in the next days 👀

ericcornelissen added a commit that referenced this pull request Feb 5, 2020
# New icons

- Elixir (#2242)
- Cinema4d (#2376)
- SEAT (#2351)
- MAAS (#2391)
- Fila (#2405)
- Ferrari (#2431)
- OpenBSD (#2426)
- Zigbee (#2382)
- Google Translate (#2430)
- LG (#2401)
- FIFA (#2404)
- Fluentd (#2415)
- Google Messages (#2367)
- JCB (#2389)
- Google Cast (#2352)
- Vuetify (#2417)
- Spinnaker icon (#2443)
- Microsoft SQL Server (#2453, 5c9c622)
- pr.co (#2456)
- Khronos Group (#2448)
- OpenGL (#2450)
- Vulkan (#2451)
- WebGL (#2452)
- WebRTC (#2454)
- Symphony (#2468)
- Veritas (#2326)
- Beatport (#2471)
- Hugo (#2455)
- Font Awesome (#2447)
- pre-commit (#2476)
- Aircall (#2466)
- Apache ECharts (#2473)
- WooCommerce (#2461)
- MIDI (#2483)
- Serverless (#2484)
- Woo (#2479)
- Katana (#2497)
- Houdini (#2498)
- Google Cardboard (#2502)
- Nuke (#2496)
- Concourse (#2427)
- NixOS (#2429)
- MariaDB (#2506)
- MariaDB Foundation (#2402)
- Google Classroom (#2482)
- Open Containers Initiative (#2490)
- Fastly (#2500)
- Peugeot (#2515)
- WP Rocket (#2432)
- Affinity Photo (#2423)
- Google Nearby (#2508)
- haveibeenpwned (#2517)
- Ferrari Corp (#2360)
- Affinity Designer (#2422)
- LabVIEW (#2435)
- Affinity Publisher (#2424)
- Affinity (#2425)
- NFC (#2501)

# Updated icons

- Twitch (#2118)
- Pandora (#2428)
- Babel (#2499)
@runxel runxel mentioned this pull request Mar 6, 2020
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants