Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Android Auto #2542

Merged
merged 5 commits into from Mar 7, 2020
Merged

Add Android Auto #2542

merged 5 commits into from Mar 7, 2020

Conversation

PeterShaggyNoble
Copy link
Member

Android Auto

Issue: Closes #2526

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Feb 7, 2020
ericcornelissen
ericcornelissen reviewed Feb 10, 2020
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVG looks good to me 👍 I'm not sure about the colour though, I feel like a blue, based on the bigger arrow, is more appropriate. If we want to source it from the colours page I think we will have to go with #4285F4

@PeterShaggyNoble
Copy link
Member Author

I can see the reasoning for Google Blue and would be OK to run with it if we get a consensus to do so.

@ericcornelissen
Copy link
Contributor

I can see the reasoning for Google Blue and would be OK to run with it if we get a consensus to do so.

Didn't realize that is Google Blue 😅 @simple-icons/maintainers or others, any opinions?

@PeterShaggyNoble PeterShaggyNoble added the in discussion There is an ongoing discussion that should be finished before we can continue label Feb 14, 2020
runxel
runxel requested changes Feb 25, 2020
View reviewed changes
Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also say #4285F4 seems more appropiate here, given that the actual logo has no green in it.

Also I just thought we might need to establish a rule where we state a how big a gap should be (in the cases where there are no official monochrome icons given, like #2663. Until now it's kind of random).

@runxel runxel added changes requested and removed in discussion There is an ongoing discussion that should be finished before we can continue labels Feb 25, 2020
@PeterShaggyNoble
Copy link
Member Author

Thanks, @runxel. Before I update, though, just want to double check that you & @ericcornelissen saw this page, where the primary brand colour is given as Android green?

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Feb 25, 2020
@runxel
Copy link
Member

runxel commented Feb 25, 2020

Yes! We both did, I think.
Maybe they are transitioning the brand, but since the icon itself is not green I personally think it's weird to have it green. 😅
Also the last time I had this app open there was no single green color to be seen for me. 🤷‍♂

@PeterShaggyNoble
Copy link
Member Author

Just making sure 😉

Colour updated.

@PeterShaggyNoble
Copy link
Member Author

Also I just thought we might need to establish a rule where we state a how big a gap should be.

I've been going with 1dp.

@PeterShaggyNoble PeterShaggyNoble removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed changes requested labels Feb 25, 2020
@runxel
Copy link
Member

runxel commented Feb 25, 2020

I've been going with 1dp.

Are you sure? 🤔
I was measuring it and I remember the gap only to be 0.5 dp...

@ericcornelissen
Copy link
Contributor

ericcornelissen commented Feb 25, 2020 •
edited

Thanks, runxel. Before I update, though, just want to double check that you & ericcornelissen saw this page, where the primary brand colour is given as Android green?

I did as well and share @runxel's opinion. This looks good to me now 👍

@PeterShaggyNoble
Copy link
Member Author

PeterShaggyNoble commented Mar 7, 2020 •
edited

Seems everyone is in agreement so hope nobody minds me merging this in myself.

@PeterShaggyNoble PeterShaggyNoble merged commit ab7ca3c into simple-icons:develop Mar 7, 2020
@PeterShaggyNoble PeterShaggyNoble deleted the androidauto branch March 9, 2020 09:40
@ericcornelissen ericcornelissen mentioned this pull request Mar 15, 2020
Merged
ericcornelissen added a commit that referenced this pull request Mar 16, 2020
@ericcornelissen
Merge pull request #2788 from simple-icons/develop
eb60aaf 
# New icons

- Bosch (#2661)
- Ulule (#2714)
- Shopware (#2698)
- Castbox (#2715)
- Plus Codes (#2717)
- Vauxhall (#2647)
- freedesktop.org (#2730)
- ESLGaming (#2731)
- BBC iPlayer (#2739)
- Transport for London (#2742)
- Gatling (#2741)
- Farfetch (#2750)
- Helly Hansen (#2747)
- Roku (#2751)
- Android Auto (#2542)
- Ford (#2632)
- Contactless Payment (#2584)
- TeamSpeak (#2700)
- Microsoft SharePoint (#2555)
- PagSeguro (#2683)
- Microsoft Visio (#2645)
- Microsoft Exchange (#2621)
- Puppet (#2694)
- vBulletin (#2721)
- PostCSS (#2759)
- AdBlock (#2761)
- HBO (#2760)
- Apple TV (#2736)
- Dash (#2728)
- Clyp (#2725)
- Vivaldi (#2724)
- iBeacon (#2729)
- Google AdSense (#2597)
- Badgr (#2768)
- Wikimedia Commons (#2685)
- ProSieben (#2627)
- Hyundai (#2641)
- Honda (#2642)
- Mazda (#2643)
- Nissan (#2649)
- Renault (#2651)
- Windows XP (#2653)
- ASKfm (#2608)
- Lubuntu (#2644)
- McDonald's (#2706)
- Eclipse Mosquitto (#2718)
- Bitwarden (#2719)
- Alfa Romeo (#2744)
- Adobe Fonts (#2776)
- ŠKODA (#2657)
- Bugatti (#2745)
- libuv (#2720)
- Volvo (#2755)
- A-Frame (#2763)
- Car Throttle (#2773)
- OpenStack (#2772)
- Adblock Plus (#2726)
- WWE (#2612)
- Phabricator (#2716)
- Toyota (#2746)
- Egnyte (#2723)
- Warner Bros (#2704)
- MAN (#2774)
- App Store (#2611)
- Chupa Chups (#2668)
- Google Calendar (#2743)
- Scania (#2775)
- niconico (#2614)
- Fiat (#2652)
- WEMO (#2619)
- Nintendo Network (#2780)
- UpLabs (#2781)
- WebMoney (#2782)

# Updated icons

- Google Maps (#2663)
- Yammer (#2558)
- Expo (#2594)
- T-mobile (#2757)
- Adobe Photoshop (#2733)
- BMW (#2737)
- Chase (#2722)
- Riot (#2732)
- Redis (#2677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcornelissen ericcornelissen ericcornelissen left review comments

@runxel runxel runxel requested changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android Auto
3 participants
@PeterShaggyNoble @ericcornelissen @runxel