Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BMW #2626

Merged
merged 4 commits into from Feb 21, 2020
Merged

Add BMW #2626

merged 4 commits into from Feb 21, 2020

Conversation

runxel
Copy link
Member

@runxel runxel commented Feb 19, 2020

Issue:
picked up #2111
tracking in #2059

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Peter posted a PDF file in #2111 (comment) that has their official monochrome logo.
The color was taken from the abandoned PR.

@runxel runxel added the new icon Issues or pull requests for adding a new icon label Feb 19, 2020
@PeterShaggyNoble
Copy link
Member

Using the "white on dark background" version from page 12 of the PDF, I'm seeing a slight difference in the inner circle in your version (in red below). Also, https://www.bmwgroup-classic.com/en/bmw-clubs/downloadbereich.html is probably a better source URL as it links to both the PDF and an EPS version of the full logo.

@PeterShaggyNoble
Copy link
Member

Oh, and should we go with one of the colours from the PDF? 🤔

@runxel
Copy link
Member Author

runxel commented Feb 19, 2020

Using the "white on dark background" version from page 12 of the PDF, I'm seeing a slight difference in the inner circle in your version (in red below).

Good catch. Updated the icon.
However – It didn't got better before precision of 6 (!) tho.... Sorry 🤷‍♂

Also, https://www.bmwgroup-classic.com/en/bmw-clubs/downloadbereich.html is probably a better source URL as it links to both the PDF and an EPS version of the full logo.

Well, it has the PDF, yes, but the EPS logo there doesn't have the BMW logo.

Oh, and should we go with one of the colours from the PDF? 🤔

Unclear to me, which of those Pantone are a good choice. Also conversion from Pantone to Hex is.... not really the best thing.

@runxel runxel added in discussion There is an ongoing discussion that should be finished before we can continue and removed changes requested labels Feb 19, 2020
@PeterShaggyNoble
Copy link
Member

Managed to get it down to a precision of 3 with this plugin - path data below.

Well, it has the PDF, yes, but the EPS logo there doesn't have the BMW logo.

Could've sworn it was the BMW logo - I must've found an EPS somewhere else and linked the wrong page in my original comment 🙄 Even so, I still think that we should use it as the source as it links to the PDF containing the monochrome logos.

Unclear to me, which of those Pantone are a good choice

Me either! 🤷‍♂ But looking at @el1f's reasoning for selecting the colour in the original PR, I think that's as good a choice as any now.

M12 0C5.371 0 0 5.372 0 12c0 6.627 5.372 12 12 12s12-5.373 12-12c0-6.628-5.372-12-12-12zm0 .369c6.423 0 11.631 5.207 11.631 11.63 0 6.424-5.208 11.632-11.632 11.632C5.576 23.631.37 18.423.37 12 .369 5.576 5.576.37 11.999.37zm-.788.607l-1.094.12-.117 3.271.847-.12.074-2.183.705 2.182h.743l.705-2.182.076 2.183.848.12-.12-3.27-1.092-.12-.788 2.3zm7.933 2.507L17.18 6.067l.605.563 2.152-.987-1.432 1.886.417.714 2.95-1.354-.416-.714-1.7.782 1.207-1.592-.285-.353-.246-.31-1.817.832 1.134-1.49zm-14.47.404a.76.76 0 0 0-.525.28l-1.74 2.18 2.557 2.04 1.806-2.263a.866.866 0 0 0-.14-1.214.86.86 0 0 0-1.171.092.773.773 0 0 0-.213-.945.797.797 0 0 0-.574-.17zm-.036.81a.362.362 0 0 1 .324.587l-.982 1.232-.568-.454.983-1.23a.362.362 0 0 1 .243-.135zM12 4.73a7.27 7.27 0 1 0 0 14.54 7.27 7.27 0 0 0 0-14.54zm-.275.376l.288.007v6.9H5.114l.003-.262H5.11a6.908 6.908 0 0 1 6.615-6.64zm2.114.252a6.901 6.901 0 0 1 5.074 6.654h-6.779l.14-.26h6.353a6.719 6.719 0 0 0-4.62-6.225zm-8.082.075a.364.364 0 0 1 .325.59L5.02 7.347l-.568-.454 1.06-1.327a.363.363 0 0 1 .243-.134zm6.256 6.718v6.76a6.904 6.904 0 0 1-6.655-5.07l.172.17a6.718 6.718 0 0 0 6.22 4.615v-6.351zm6.897.008a6.9 6.9 0 0 1-6.749 6.751l.113-.278v-6.357h6.344Z

@runxel
Copy link
Member Author

runxel commented Feb 20, 2020

Great, I've updated everything.

@PeterShaggyNoble
Copy link
Member

Sweet, all looks good to me now, @runxel but I'll leave it to one of the other @simple-icons/maintainers to throw another eye over and merge in, in case they want to weigh in on the colour choice.

Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @runxel and thanks also to @PeterShaggyNoble and @el1f 👏

@phatbhoy67 phatbhoy67 merged commit e72f052 into simple-icons:develop Feb 21, 2020
@runxel runxel deleted the bmw branch February 21, 2020 20:49
@ericcornelissen ericcornelissen removed the in discussion There is an ongoing discussion that should be finished before we can continue label Mar 1, 2020
ericcornelissen added a commit that referenced this pull request Mar 1, 2020
# New icons

- YouTube Studio (#2481)
- Cloudsmith (#1071)
- easyJet (#2598)
- Aer Lingus (#2607)
- Ryanair (#2606)
- JSON Web Tokens (#2605)
- Google Earth (#2529)
- SmartThings (#2618)
- GitHub Actions (#2620)
- XAML (#2522)
- Google Street View (#2533, #2707)
- DC (#2534)
- Suzuki (#2630)
- Mitsubishi (#2631)
- General Motors (#2638)
- Tata (#2637)
- Porsche (#2635)
- BMW (#2626)
- LineageOS (#2609)
- Archicad (#2633)
- Stellar (#2613)
- Try It Online (#2622)
- Prezi (#2623)
- The Washington Post (#2655)
- CNN (#2656)
- CloudCannon (#2662)
- Craft CMS (#2666)
- micro:bit (#2624)
- Cesium (#2660)
- Harbor (#2650)
- QIWI (#2669)
- Staffbase (#2673)
- 1001Tracklists (#2678)
- PlayStation 2 (#2679)
- Antena 3 (#2680)
- FIRST (#2681)
- Poly (#2682)
- Spinrilla (#2696)
- Platzi (#2684)
- GitKraken (#2697)
- Threema (#2699)
- Apollo GraphQL (#2589)
- OnStar (#2701)
- Elm (#2702)
- Iconify (#2703)
- Vivino (#2705)
- Pokémon (#2408)
- Hive (#2674)

# Updated icons

- Microsoft Access (#2541)
- Microsoft Excel (#2549)
- Microsoft Office (#2550)
- Microsoft OneDrive (#2551)
- Microsoft OneNote (#2552)
- Microsoft PowerPoint (#2554)
- Microsoft Teams (#2556)
- Wix (#2596)
- Microsoft Outlook (#2553)
- Google Fit (#2707)
- Google Lens (#2707)
- Google Pay (#2707)
- Google Play (#2707)
- Google Wear OS (#2707)
@gizmecano gizmecano mentioned this pull request Mar 5, 2020
48 tasks
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Mar 5, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants