New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BMW #2626
Add BMW #2626
Conversation
Using the "white on dark background" version from page 12 of the PDF, I'm seeing a slight difference in the inner circle in your version (in red below). Also, https://www.bmwgroup-classic.com/en/bmw-clubs/downloadbereich.html is probably a better source URL as it links to both the PDF and an EPS version of the full logo. |
Oh, and should we go with one of the colours from the PDF? 🤔 |
Good catch. Updated the icon.
Well, it has the PDF, yes, but the EPS logo there doesn't have the BMW logo.
Unclear to me, which of those Pantone are a good choice. Also conversion from Pantone to Hex is.... not really the best thing. |
Managed to get it down to a precision of 3 with this plugin - path data below.
Could've sworn it was the BMW logo - I must've found an EPS somewhere else and linked the wrong page in my original comment 🙄 Even so, I still think that we should use it as the source as it links to the PDF containing the monochrome logos.
Me either! 🤷♂ But looking at @el1f's reasoning for selecting the colour in the original PR, I think that's as good a choice as any now.
|
Great, I've updated everything. |
Sweet, all looks good to me now, @runxel but I'll leave it to one of the other @simple-icons/maintainers to throw another eye over and merge in, in case they want to weigh in on the colour choice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @runxel and thanks also to @PeterShaggyNoble and @el1f 👏
# New icons - YouTube Studio (#2481) - Cloudsmith (#1071) - easyJet (#2598) - Aer Lingus (#2607) - Ryanair (#2606) - JSON Web Tokens (#2605) - Google Earth (#2529) - SmartThings (#2618) - GitHub Actions (#2620) - XAML (#2522) - Google Street View (#2533, #2707) - DC (#2534) - Suzuki (#2630) - Mitsubishi (#2631) - General Motors (#2638) - Tata (#2637) - Porsche (#2635) - BMW (#2626) - LineageOS (#2609) - Archicad (#2633) - Stellar (#2613) - Try It Online (#2622) - Prezi (#2623) - The Washington Post (#2655) - CNN (#2656) - CloudCannon (#2662) - Craft CMS (#2666) - micro:bit (#2624) - Cesium (#2660) - Harbor (#2650) - QIWI (#2669) - Staffbase (#2673) - 1001Tracklists (#2678) - PlayStation 2 (#2679) - Antena 3 (#2680) - FIRST (#2681) - Poly (#2682) - Spinrilla (#2696) - Platzi (#2684) - GitKraken (#2697) - Threema (#2699) - Apollo GraphQL (#2589) - OnStar (#2701) - Elm (#2702) - Iconify (#2703) - Vivino (#2705) - Pokémon (#2408) - Hive (#2674) # Updated icons - Microsoft Access (#2541) - Microsoft Excel (#2549) - Microsoft Office (#2550) - Microsoft OneDrive (#2551) - Microsoft OneNote (#2552) - Microsoft PowerPoint (#2554) - Microsoft Teams (#2556) - Wix (#2596) - Microsoft Outlook (#2553) - Google Fit (#2707) - Google Lens (#2707) - Google Pay (#2707) - Google Play (#2707) - Google Wear OS (#2707)
Issue:
picked up #2111
tracking in #2059
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Peter posted a PDF file in #2111 (comment) that has their official monochrome logo.
The color was taken from the abandoned PR.