Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape icon title for object key #2710

Merged
merged 3 commits into from Mar 2, 2020
Merged

Escape icon title for object key #2710

merged 3 commits into from Mar 2, 2020

Conversation

ericcornelissen
Copy link
Contributor

Issue: #2706

Description

Updates the build script to escape ' in object keys.

@ericcornelissen ericcornelissen added meta Issues or pull requests regarding the project or repository itself package Pull requests or issues that affect the NPM package labels Mar 1, 2020
@ericcornelissen ericcornelissen marked this pull request as ready for review March 1, 2020 08:42
@PeterShaggyNoble
Copy link
Member

Looks good to me, Eric - thanks for the quick fix 🙂

@PeterShaggyNoble PeterShaggyNoble merged commit 412ccc0 into simple-icons:develop Mar 2, 2020
@ericcornelissen ericcornelissen deleted the build/apostrophe-in-title branch March 11, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterShaggyNoble PeterShaggyNoble Awaiting requested review from PeterShaggyNoble

Assignees
No one assigned
Labels
meta Issues or pull requests regarding the project or repository itself package Pull requests or issues that affect the NPM package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericcornelissen @PeterShaggyNoble