Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep track of brand guidelines/presskits/etc. explicitly #2846

Merged
merged 8 commits into from
Jan 17, 2021
Merged

Keep track of brand guidelines/presskits/etc. explicitly #2846

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
414418a
Add optional field for brand guidelines to JSON schema
ericcornelissen Mar 25, 2020
ad91802
Add some example guidelines
ericcornelissen Mar 25, 2020
717ef74
Update the Contributing Guidelines
ericcornelissen Mar 25, 2020
373bf9e
Update .jsonlintschema
ericcornelissen Mar 29, 2020
2b10d93
Merge branch 'develop' into track-guidelines
ericcornelissen Jul 4, 2020
8762a4d
Merge branch 'develop' into track-guidelines
ericcornelissen Oct 6, 2020
c94df99
Merge branch 'develop' into track-guidelines
ericcornelissen Nov 29, 2020
cde1331
Merge branch 'develop' into track-guidelines
ericcornelissen Jan 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions .jsonlintschema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@
"type": "string",
"pattern": "^https?://[^\\s]+$",
"required": true
},
"guidelines": {
"description": "The brand guidelines for the icon and/or color",
"type": "string",
"pattern": "^https?://[^\\s]+$",
"required": false
}
},
"required": true
Expand Down
5 changes: 4 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,16 @@ Icon metadata should be added to the `_data/simple-icons.json` file. Each icon i
* A `hex` color value that matches the brand's primary color. All uppercase and without the `#` pound symbol.)
* The `source` URL of the logo being used. There are [more details below](#source-guidelines).

There is also an optional field that may be used to specify the brand guidelines/presskit/etc. This is useful if the SVG file was sourced from a different place.

Here is the object for The Movie Database as an example:

```json
{
"title": "The Movie Database",
"hex": "01D277",
"source": "https://www.themoviedb.org/about/logos-attribution"
"source": "https://www.themoviedb.org/about/logos-attribution",
"guidelines": "https://www.themoviedb.org/about/logos-attribution"
}
```

Expand Down
15 changes: 10 additions & 5 deletions _data/simple-icons.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1433,7 +1433,8 @@
{
"title": "Corona Engine",
"hex": "F96F29",
"source": "https://coronalabs.com/"
"source": "https://coronalabs.com/",
"guidelines": "https://coronalabs.com/presskit.pdf"
},
{
"title": "Corona Renderer",
Expand Down Expand Up @@ -2163,7 +2164,8 @@
{
"title": "Firebase",
"hex": "FFCA28",
"source": "https://firebase.google.com/brand-guidelines/"
"source": "https://firebase.google.com/brand-guidelines/",
"guidelines": "https://firebase.google.com/brand-guidelines/"
},
{
"title": "Firefox",
Expand Down Expand Up @@ -2413,7 +2415,8 @@
{
"title": "GitHub",
"hex": "181717",
"source": "https://github.com/logos"
"source": "https://github.com/logos",
"guidelines": "https://github.com/logos"
},
{
"title": "GitHub Actions",
Expand Down Expand Up @@ -3648,7 +3651,8 @@
{
"title": "LG",
"hex": "A50034",
"source": "https://en.wikipedia.org/wiki/LG_Corporation"
"source": "https://en.wikipedia.org/wiki/LG_Corporation",
"guidelines": "https://www.lg.com/global/about-lg-brand-identity"
},
{
"title": "LGTM",
Expand Down Expand Up @@ -6443,7 +6447,8 @@
{
"title": "Toyota",
"hex": "282830",
"source": "https://www.toyota.ie/world-of-toyota/articles-news-events/2020/new-brand-design.json"
"source": "https://www.toyota.ie/world-of-toyota/articles-news-events/2020/new-brand-design.json",
"guidelines": "https://www.toyota.com/brandguidelines/"
},
{
"title": "TrainerRoad",
Expand Down