Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Adobe Typekit & Greenkeeper #2943

Merged

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Apr 17, 2020

Issues: see table below

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Opening this draft now so we can start gathering up icons that need to be removed in v3 in a single PR and close out a few issues. The branch on my fork is set up so that any other member of the @simple-icons/maintainers team can commit any additional removals directly to it.

In this instance, I'd suggest when merging this that we do a merge commit for easier tracking. Scratch that, I made a mess of it!

Affected Icons

Icon Reason Issue
Adobe Typekit Rebranded as Adobe Fonts #2771, #2776
Greenkeeper Discontinued (2020-06-03) greenkeeper.io

@PeterShaggyNoble PeterShaggyNoble added update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both breaking change Issues or pull requests that include a breaking change and scheduled for the next major release labels Apr 17, 2020
@PeterShaggyNoble PeterShaggyNoble added this to the v3.0.0 milestone Apr 17, 2020
@PeterShaggyNoble
Copy link
Member Author

Added Greenkeeper to this as they're discontinuing their service next month.

@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jun 23, 2020
@PeterShaggyNoble PeterShaggyNoble changed the title Remove Various Icons Remove Various Icons (v3) Jun 28, 2020
@PeterShaggyNoble PeterShaggyNoble changed the title Remove Various Icons (v3) Remove Adobe Typekit & Greenkeeper Jun 28, 2020
@PeterShaggyNoble PeterShaggyNoble marked this pull request as ready for review June 28, 2020 13:26
@ericcornelissen ericcornelissen merged commit 4522a2b into simple-icons:develop Jul 2, 2020
@PeterShaggyNoble PeterShaggyNoble deleted the update/removals branch July 2, 2020 16:50
ericcornelissen added a commit that referenced this pull request Jul 5, 2020
New Icons

- Altium Designer (#3139)
- Facebook Gaming (#3040)
- Firefox Browser (#3266)
- HEY (#3273)
- JFrog (#3272)
- JFrog Bintray (#3261)
- Jira Software (#3267)
- Payoneer (#3262)
- Pimcore (#3246)

Updated Icons

- Jira (#3267)
- Moleculer (#2942)
- Odnoklassniki (#3284)
- Simple Icons (#3137)

Renamed Icons

- _Adobe Premiere_ to _Adobe Premiere Pro_ (#2942)
- _Cassandra_ to _Apache Cassandra_ (#2942)
- _Line_ to _LINE_ (#3283)
- _Mojang_ to _Mojang Studios_ (#2942)
- _Mozilla Firefox_  to _Firefox_ (#3266)
- _Mozilla Thunderbird_ to _Thunderbird_ (#3282)
- _Rails_ to _Ruby on Rails_ (#2942)
- _Tik Tok_ to _TikTok_ (#2942)
- _Zeit_ to _Vercel_ (#2942)

Removed Icons

- Adobe Typekit (#2943)
- Greenkeeper (#2943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Issues or pull requests that include a breaking change and scheduled for the next major release update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants