Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jasmine #2953

Closed
wants to merge 6 commits into from
Closed

Add Jasmine #2953

wants to merge 6 commits into from

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Apr 18, 2020

jasmine-preview

Issue: Closes #2948

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Vector logo from repository and colour #8A4182 from website stylesheet.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Apr 19, 2020
@PeterShaggyNoble
Copy link
Member

Thanks for taking this one on, @mondeja.

However, you've somehow managed to vertically flip your version (in red below). Note, as well, that the icon in the source isn't quite a perfect circle; it's a shade wider than it is high. The only other, minor thing is to include the commit has in the source URL: https://github.com/jasmine/jasmine/blob/8991b1bba39b5b7e89fc5eeb07ae271a684cb1a4/images/jasmine-horizontal.svg

@mondeja
Copy link
Member Author

mondeja commented Apr 20, 2020

Thanks @PeterShaggyNoble. It's fixed now:

jasmine-preview

However, keep in mind that SVGO configuration of 3 decimal digits can force the path to be a perfect circle. I've tested with SVGOMG and this problem appears, so I've setted the precision to 5 decimals optimizing the vector this time.

@PeterShaggyNoble
Copy link
Member

SVG looks perfect now, @mondeja, nice work 👍

Although, personally, I don't think maintaining a difference of 0.002 in the width is worth the sacrifice and increased file size of increasing the precision to 5. If you'll allow me, I'm going to see if I can improve on the precision at all while, hopefully, maintaining the dimensions.

@PeterShaggyNoble
Copy link
Member

Actually, looking at the path in detail, it doesn't looks like we're sacrificing all that much in file size with a precision of 5.

However, using this SVGO plugin for Inkscape I managed to get the precision down to 3 while maintaining the dimensions, but now the path is 0.001 off horizontal centre:

M11.59 19.648h.772v-3.785h-.771zM4.718 14.62l-.238-.733 3.6-1.17.238.734-3.6 1.17m4.645-5.763L7.137 5.795l.624-.454 2.225 3.063-.624.453m5.315.028l-.624-.453 2.225-3.063.624.453-2.225 3.063m4.591 5.78l-3.6-1.17.238-.733 3.6 1.17-.238.733M12.001 0C5.384 0 0 5.382 0 11.998 0 18.616 5.384 24 12 24s11.998-5.384 11.998-12.002C24 5.382 18.617 0 12.001 0zm0 2.43c5.283 0 9.569 4.283 9.569 9.568 0 5.287-4.286 9.572-9.57 9.572-5.285 0-9.57-4.285-9.57-9.572 0-5.285 4.285-9.569 9.57-9.569m1.553 7.961l.575 1.768.747.243 4.736-1.539-.86-2.646-4.736 1.54-.462.634m.337 2.502l-1.504 1.092v.786l2.927 4.029 2.25-1.635-2.927-4.03-.746-.242m-2.275 1.093l-1.504-1.093-.747.243-2.927 4.029 2.25 1.635 2.928-4.03v-.784m-1.743-1.826l.575-1.768-.462-.636-4.736-1.539-.86 2.646 4.737 1.54.746-.243m1.199-2.222h1.858l.462-.635v-4.98H10.61v4.98l.462.635

Any of the other @simple-icons/maintainers want to weigh in here as to what our best option is?

@PeterShaggyNoble PeterShaggyNoble added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed and removed changes requested labels Apr 21, 2020
@runxel
Copy link
Member

runxel commented Apr 21, 2020

We have done some optimizing in the past, mostly in cases where we think the source file itself can't be trusted/doesn't look as intended.
With a circle just being a shade not a circle I personally would always assume that this must be an error. I'd be okay with the circle being perfectly round :D

@PeterShaggyNoble PeterShaggyNoble added changes requested and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Apr 22, 2020
@mondeja
Copy link
Member Author

mondeja commented Apr 24, 2020

I've finally used the path that @PeterShaggyNoble shared. Thanks for the plugin, it's very useful.

@PeterShaggyNoble
Copy link
Member

Sorry, @mondeja, looks like this one fell between the cracks. Upon reflection, I agree with @runxel's comment that:

With a circle just being a shade not a circle I personally would always assume that this must be an error.

Could you revert back to your precision 3, 24*24 version, please? Sorry for the hassle.

@mondeja
Copy link
Member Author

mondeja commented Jun 2, 2020

I've removed this branch by mistake, so it's updated on #3152

@mondeja mondeja closed this Jun 2, 2020
@PeterShaggyNoble PeterShaggyNoble added abandoned Pull requests that have been abandoned by the contributor and removed changes requested labels Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned Pull requests that have been abandoned by the contributor new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jasmine
4 participants