New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jasmine #2953
Add Jasmine #2953
Conversation
Thanks for taking this one on, @mondeja. However, you've somehow managed to vertically flip your version (in red below). Note, as well, that the icon in the source isn't quite a perfect circle; it's a shade wider than it is high. The only other, minor thing is to include the commit has in the source URL: https://github.com/jasmine/jasmine/blob/8991b1bba39b5b7e89fc5eeb07ae271a684cb1a4/images/jasmine-horizontal.svg |
Thanks @PeterShaggyNoble. It's fixed now: However, keep in mind that SVGO configuration of 3 decimal digits can force the path to be a perfect circle. I've tested with SVGOMG and this problem appears, so I've setted the precision to 5 decimals optimizing the vector this time. |
SVG looks perfect now, @mondeja, nice work 👍 Although, personally, I don't think maintaining a difference of |
Actually, looking at the path in detail, it doesn't looks like we're sacrificing all that much in file size with a precision of 5. However, using this SVGO plugin for Inkscape I managed to get the precision down to 3 while maintaining the dimensions, but now the path is
Any of the other @simple-icons/maintainers want to weigh in here as to what our best option is? |
We have done some optimizing in the past, mostly in cases where we think the source file itself can't be trusted/doesn't look as intended. |
I've finally used the path that @PeterShaggyNoble shared. Thanks for the plugin, it's very useful. |
Sorry, @mondeja, looks like this one fell between the cracks. Upon reflection, I agree with @runxel's comment that:
Could you revert back to your precision 3, |
I've removed this branch by mistake, so it's updated on #3152 |
Issue: Closes #2948
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Vector logo from repository and colour
#8A4182
from website stylesheet.