Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hive Blockchain #3008

Merged
merged 11 commits into from Feb 19, 2021
Merged

Add Hive Blockchain #3008

merged 11 commits into from Feb 19, 2021

Conversation

selabie68
Copy link
Contributor

@selabie68 selabie68 commented Apr 29, 2020 •
edited by PeterShaggyNoble

Hive

Issue: Closes #2998

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Created using the brand assets form official site https://hive.io/brand/
Color located on the same page.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Apr 30, 2020
@PeterShaggyNoble
Copy link
Member

Thanks for taking this one on, @selabie68 👍

One small change, though: your path is coming in at 24.013 wide, rather than 24.

We'll also need to figure out how best to avoid the name clash with our existing Hive icon, which is under discussion in #2260. Although the name you've chosen makes sense, changing a brand's name in this manner to avoid the clash doesn't sit well with me.

@PeterShaggyNoble PeterShaggyNoble added changes requested pending Issues that are pending because of e.g. a scheduled brand update labels May 5, 2020
@PeterShaggyNoble

This comment has been minimized.

Sign in to view
@selabie68

This comment has been minimized.

Sign in to view
@PeterShaggyNoble

This comment has been minimized.

Sign in to view
PeterShaggyNoble
PeterShaggyNoble approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @selabie68 - the SVG looks perfect now 👍

Once, #2260 is resolved this can me merged in.

@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jun 29, 2020
Closed
7 tasks
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Feb 10, 2021
Merged
@PeterShaggyNoble
Copy link
Member

With #2260 now resolved by #4918; we can finally get this one merged in. I've made all the necessary changes to the JSON & SVG file but, as this is our first icon to use a custom slug, can one of the other @simple-icons/maintainers throw an eye over it to make sure all is correct.

@ericcornelissen ericcornelissen removed the pending Issues that are pending because of e.g. a scheduled brand update label Feb 19, 2021
@ericcornelissen
Copy link
Contributor

ericcornelissen commented Feb 19, 2021 •
edited

All looks good to me @PeterShaggyNoble 👍 Could you merge develop into this branch just to be sure? (for some reason I wasn't able to push to this branch, even though you seem to be able to...)

Also, perhaps we should hold off a little longer on merging this until #5002 is resolved?

@PeterShaggyNoble
Copy link
Member

Could you merge develop into this branch just to be sure?

That's done, @ericcornelissen

perhaps we should hold off a little longer on merging this until #5002 is resolved?

I'm OK with merging it now; we're not going to have a huge amount of icons with slugs before that PR is merged so we should be able to field the small handful of questions we may get in the meantime about how to use them.

@ericcornelissen
Copy link
Contributor

Fair enough, then with the build succeeding with develop merged in I will go ahead and merge this.

@ericcornelissen ericcornelissen merged commit ae266ef into simple-icons:develop Feb 19, 2021
@ericcornelissen
Copy link
Contributor

Thank you very much for your work on this one @selabie68 🎉 I'm glad we were finally able to merge it 😄

@github-actions github-actions bot mentioned this pull request Feb 21, 2021
Merged
ericcornelissen added a commit that referenced this pull request Feb 21, 2021
@ericcornelissen
Release 39 new icons and 18 updated icons (v4.12.0)
612c336 
# New Icons

- Aerospike (#4994)
- Alibaba.com (#4953)
- ANA (#4821)
- Apache Hive (#4882)
- Aparat (#5046)
- British Airways (#4908)
- ChatBot (#4877)
- Codeberg (#4757)
- Cycling '74 (#4982)
- Databricks (#5037)
- Dogecoin (#4762)
- Ethiopian Airlines (#4909)
- Handshake (#5071)
- Handshake (Protocol) (#5072)
- HelpDesk (#4895)
- Hibernate (#4873)
- Hive (Blockchain) (#3008)
- IEEE (#4989)
- Juniper Networks (#4894)
- Linux Containers (#3155)
- Lion Air (#4959)
- Miro (#5077)
- MobX (#4986)
- MobX-State-Tree (#4984)
- MODX (#4893)
- Naver (#4987)
- OnlyFans (#5059)
- OpenFaaS (#4980)
- Podman (#4774)
- Prisma (#5052)
- Qatar Airways (#4869)
- Resurrection Remix OS (#4756)
- Rider (#5041)
- Sefaria (#4988)
- semantic-release (#4995)
- sharp (#4998)
- Shotcut (#4879)
- teratail (#4897)
- WebdriverIO (#5042)

# Updated Icons

- Citroën (#5005)
- DS Automobiles (#5006)
- GNU (#4945)
- GNU social (#4945)
- Google Play (#4505)
- IconJar (#3909)
- IntelliJ IDEA (#5041)
- Intercom (#5041)
- InVision (#5048)
- Kotlin (#5041)
- Maserati (#5009)
- Opel (#5012)
- Peugeot (#5013)
- PhpStorm (#5041)
- PyCharm (#5041)
- TeamCity (#5041)
- Textpattern (#5065)
- WebStorm (#5041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HIVE Blockchain
3 participants
@selabie68 @PeterShaggyNoble @ericcornelissen