Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish 5 new icons #3019

Merged
merged 8 commits into from
May 3, 2020
Merged

Publish 5 new icons #3019

merged 8 commits into from
May 3, 2020

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 3, 2020

this Pull Request was automatically generated

The new version will be: v2.11.0

New Icons

renovate bot and others added 7 commits April 27, 2020 12:17
Co-authored-by: Renovate Bot <bot@renovateapp.com>
* Add `npm run lint` command that runs all our linting commands at once

Using npm-run-all [1], following a comment from a contributor [2].

--
1. https://www.npmjs.com/package/npm-run-all
2. 
#2958 (comment)

* Mention new `npm run lint` command in the contributing guidelines
@github-actions github-actions bot added the release Pull requests that released a new version label May 3, 2020
@ericcornelissen ericcornelissen changed the title Publish 15 new icons Publish 5 new icons May 3, 2020
@ericcornelissen ericcornelissen merged commit 6523bca into master May 3, 2020
ericcornelissen added a commit to simple-icons/release-action that referenced this pull request May 6, 2020
Due to a misunderstanding of how the PRs are sorted, the last release 
notes [1] included too many changes. This was caused by the fact that 
some of the PRs included in the release before it were updated after 
that release was merged (e.g. the brach was removed).

Now, when all changes of all PRs updated after the last release are 
gathered, the time at which the PR of that file was merged is compared 
to the time at which the previous release was merged, and the file is 
included in the next release accordingly.

For this comparison, Moment.JS was used as the GitHub API returns the 
merged time as a string rather then a standard Unix epoch timestamp.

--
1.  simple-icons/simple-icons#3019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Pull requests that released a new version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants