Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Razer #3022

Merged
merged 7 commits into from May 26, 2020
Merged

Add Razer #3022

merged 7 commits into from May 26, 2020

Conversation

EinsEli
Copy link
Contributor

@EinsEli EinsEli commented May 4, 2020

razer

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The logo is from wikipedia and the colors are from the same image.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label May 4, 2020
@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented May 5, 2020

Thanks for the PR, @EinsEli.

I had a quick look around their site for an official and better quality vector version of that logo but couldn't find one. However, I would suggest using this version instead as it is more recent but still with its own little imperfections which we could do with cleaning up.

I agree with your choice of colour as it's used on their site, too. Although, in the absence of any official guidelines, I could see a case being made for one of the greys they use.

Alexa rank: ~2.8k

@ericcornelissen
Copy link
Contributor

I agree with your choice of colour as it's used on their site, too. Although, in the absence of any official guidelines, I could see a case being made for one of the greys they use.

Chiming in here just to say that green is definitely the brand colour of Razer.

@EinsEli
Copy link
Contributor Author

EinsEli commented May 7, 2020

I've changed the icon to the one on wikipedia now

@PeterShaggyNoble
Copy link
Member

Thanks for the update, @EinsEli.

The new path however, is coming in a 24.001 in height, rather than 24. There are also a number of imperfections in the source file (examples below) which we should consider fixing.

@EinsEli
Copy link
Contributor Author

EinsEli commented May 7, 2020

Thanks for the update, @EinsEli.

The new path however, is coming in a 24.001 in height, rather than 24. There are also a number of imperfections in the source file (examples below) which we should consider fixing.

Should be fixed now :)

@finnkuhn
Copy link
Contributor

finnkuhn commented May 8, 2020

Thanks for the PR, @EinsEli.

I had a quick look around their site for an official and better quality vector version of that logo but couldn't find one. However, I would suggest using this version instead as it is more recent but still with its own little imperfections which we could do with cleaning up.

I agree with your choice of colour as it's used on their site, too. Although, in the absence of any official guidelines, I could see a case being made for one of the greys they use.

Alexa rank: ~2.8k

I tried finding their logo on their website too and found this version as an .svg: https://d4kkpd69xt9l7.cloudfront.net/sys-master/images/h6c/he1/8858452525086/wordmark.svg

@ericcornelissen
Copy link
Contributor

@Orchomenos I don't think using the wordmark is appropriate for Razer, but thanks for the help.

@PeterShaggyNoble
Copy link
Member

Thanks for your work on this one, @EinsEli 👍 I'd be happy to merge this in as-is. I'm going to hold off for a day or 2, though, just to give the other @simple-icons/maintainers an opportunity to double check that we didn't miss any other imperfections in the source that should be fixed.

My first instinct upon seeing their website was that we should be using the wordmark, too, @Orchomenos, or maybe just the E. However, from their favicon and this page, I think the snakes icon is the correct choice.

@PeterShaggyNoble PeterShaggyNoble added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed and removed changes requested labels May 12, 2020
@PeterShaggyNoble
Copy link
Member

As there have been no objections, I'm going to go ahead and merge this in. Thanks again for your work on it, @EinsEli 👍

@PeterShaggyNoble PeterShaggyNoble merged commit b780524 into simple-icons:develop May 26, 2020
@PeterShaggyNoble PeterShaggyNoble removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label May 26, 2020
ericcornelissen added a commit that referenced this pull request May 31, 2020
# New Icons

- Carto (#3103)
- ClickUp (#3128)
- Consul (#3078)
- Razer (#3022)
- Sky (#2996)
- The Conversation (#3065)
- YouTube Music (#3098)
- iHeartRadio (#3106)

# Updated Icons

- Google Scholar (#3093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants