Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Adobe Creative Cloud #3032

Merged
merged 2 commits into from May 14, 2020
Merged

Update Adobe Creative Cloud #3032

merged 2 commits into from May 14, 2020

Conversation

PeterShaggyNoble
Copy link
Member

Adobe Creative Cloud

Issue: #2734 and separated out of #2769

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon & colour from this SVG found in source URL header.

Possible alternative treatment based on the icon in the header of fonts.adobe.com and in use in a few other places:

Adobe Creative Cloud

Comparison

With our current version in red.
Adobe Creative Cloud

@PeterShaggyNoble PeterShaggyNoble added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label May 6, 2020
phatbhoy67
phatbhoy67 suggested changes May 10, 2020
View reviewed changes
Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @PeterShaggyNoble thanks for updating this one. 👍

Can you please centre the icon on the horizontal axis, it's out by a miniscule amount. Other than that I am happy to merge this PR.

As regards the alternative treatment, that version seems to be used as the app icon, whereas the PR version appears to represent the brand, on that basis I am happy with the PR version chosen - although it might be better to get a consensus from the other @simple-icons/maintainers on that score.

@PeterShaggyNoble
Copy link
Member Author

Well spotted, @phatbhoy67, thanks. There was a clip-path in the source that I'd missed which was throwing things off slightly; should be OK now.

I also think that, as it's the one they use on product pages, that the version in the PR is the one we should go with. It's also clearer and more easily identifiable at 24*24.

phatbhoy67
phatbhoy67 approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @PeterShaggyNoble 👍

@phatbhoy67 phatbhoy67 merged commit 83831a1 into simple-icons:develop May 14, 2020
@github-actions github-actions bot mentioned this pull request May 17, 2020
Merged
ericcornelissen added a commit that referenced this pull request May 17, 2020
@ericcornelissen
Release 1 new icon and 1 updated icons (v2.13.0)
6a9ee2e 
# New Icons

- Rancher (#3035)

# Updated Icons

- Adobe Creative Cloud (#3032)
@PeterShaggyNoble PeterShaggyNoble deleted the update/adobecreativecloud branch May 19, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phatbhoy67 phatbhoy67 phatbhoy67 approved these changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PeterShaggyNoble @phatbhoy67