Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Carto #3080

Closed
wants to merge 1 commit into from
Closed

Add Carto #3080

wants to merge 1 commit into from

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented May 13, 2020

carto-preview

Issue: Closes #3075

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@mondeja mondeja changed the title Add Carto icon Add Carto May 13, 2020
@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label May 14, 2020
phatbhoy67
phatbhoy67 suggested changes May 23, 2020
View reviewed changes
Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mondeja thanks for your work on this icon. 👍

Looking at the PR, the icon is not quite 24px wide, and currently not centered, can you please make the necessary changes update the PR.

@mondeja
Copy link
Member Author

mondeja commented May 23, 2020

I have created a new pull request for this with requested changes because I've deleted the branch by mistake.

@mondeja mondeja closed this May 23, 2020
@PeterShaggyNoble PeterShaggyNoble added abandoned Pull requests that have been abandoned by the contributor and removed changes requested labels May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phatbhoy67 phatbhoy67 phatbhoy67 requested changes

Assignees
No one assigned
Labels
abandoned Pull requests that have been abandoned by the contributor new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carto
3 participants
@mondeja @phatbhoy67 @PeterShaggyNoble