Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google Scholar #3093

Merged
merged 1 commit into from May 30, 2020

Conversation

davidjb
Copy link
Contributor

@davidjb davidjb commented May 19, 2020

Issue: Closes #3081

scholar-1 5pt

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Based upon the file at https://commons.wikimedia.org/wiki/File:Google_Scholar_logo.svg with insetting applied to the mortarboard triangles and head circle segments to distinguish the parts. The hex colour has been adjusted to match the left-hand side of the coloured mortarboard, which also happens to be the colour of the Gs in the Google logo (which matches other Google brands as well).

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label May 19, 2020
@ericcornelissen ericcornelissen linked an issue May 19, 2020 that may be closed by this pull request
@PeterShaggyNoble PeterShaggyNoble added update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both and removed new icon Issues or pull requests for adding a new icon labels May 19, 2020
@runxel
Copy link
Member

runxel commented May 19, 2020

Hey @davidjb, thanks for taking care of this one.
However it looks like the stroke width differs from each other. They all should have a width of 1 pt. (At least this is, what we once settled on informally, when doing work like this)
Also the crossbar should sit higher; if you compare it to the original.

@PeterShaggyNoble
Copy link
Member

I was thinking of just a single cutout on the mortarboard, along the lines of the below; what are other people's thoughts?

@davidjb
Copy link
Contributor Author

davidjb commented May 20, 2020

@PeterShaggyNoble Looks good and far clearer as to what it is at larger sizes than mine 👍

@ericcornelissen
Copy link
Contributor

That is also what I was expecting @PeterShaggyNoble

@davidjb
Copy link
Contributor Author

davidjb commented May 26, 2020

Did you want me to update/finish my PR with your icon, @PeterShaggyNoble? Or let you update it in the repo separately?

@ericcornelissen
Copy link
Contributor

ericcornelissen commented May 27, 2020

Did you want me to update/finish my PR with your icon, @PeterShaggyNoble? Or let you update it in the repo separately?

I'm guessing the intention was for you to update the PR based on the SVG provided PNG shown by Peter, could you do that?

@davidjb
Copy link
Contributor Author

davidjb commented May 27, 2020

Sure, more than happy to do it. The preview is just a PNG though - is there an svg available?

@PeterShaggyNoble
Copy link
Member

Yeah, that was just a rough mock-up I did, @davidjb.

@davidjb davidjb force-pushed the update-googlescholar branch 2 times, most recently from f83c1c9 to 7823fcd Compare May 29, 2020 04:38
@davidjb
Copy link
Contributor Author

davidjb commented May 29, 2020

scholar-1 5pt

Updated the PR. I had tried a 1pt gouge out of the mortarboard but at the smallest size (eg 24px) the distinction was too slight. This is 1.5pt and thus more obvious when small.

Screen Shot 2020-05-29 at 14 35 47
Screen Shot 2020-05-29 at 14 35 39

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now 👍 What do you say @PeterShaggyNoble?

Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I think, Peter will agree. :)

@PeterShaggyNoble
Copy link
Member

Perfect! 😁 Nice work, @davidjb

Before we merge this in, can you update the source URL to the logos page on Wikimedia: https://commons.wikimedia.org/wiki/File:Google_Scholar_logo.svg?

Nice catch on the colour, by the way. Everyone else OK with changing it to Google blue?

@davidjb
Copy link
Contributor Author

davidjb commented May 29, 2020

All done @PeterShaggyNoble, thanks for the feedback.

For the URL, I'd followed the example of others' source URLs - there are several others that use the direct link to upload.wikimedia.org.

@ericcornelissen
Copy link
Contributor

For the URL, I'd followed the example of others' source URLs - there are several others that use the direct link to upload.wikimedia.org.

No problem, at some point we set guidelines on wikimedia URLs but we didn't update the existing URLs that didn't meet those guidelines. Perhaps we should...

Anyway, thanks a bunch for updating the Google Scholar icon! 🎊

@ericcornelissen ericcornelissen merged commit e707a7c into simple-icons:develop May 30, 2020
ericcornelissen added a commit that referenced this pull request May 31, 2020
# New Icons

- Carto (#3103)
- ClickUp (#3128)
- Consul (#3078)
- Razer (#3022)
- Sky (#2996)
- The Conversation (#3065)
- YouTube Music (#3098)
- iHeartRadio (#3106)

# Updated Icons

- Google Scholar (#3093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update: Google Scholar Icon
4 participants