Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter to check svg path dimensions #3107

Merged
merged 3 commits into from Jun 10, 2020
Merged

Add linter to check svg path dimensions #3107

merged 3 commits into from Jun 10, 2020

Commits on Jun 9, 2020

  1. Add linter to check svg path dimensions 

    Float precision is set at 3 which is the default for svgo in .svgo.yml;
precision can be raised over time.

This adds an ignore file with the current paths of non-conforming icons.

This also changes the name of the icon title linter as well so it reads
more nicely than "custom".
    @davidjb
    davidjb committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    4a18c51 View commit details
    Browse the repository at this point in the history

  2. Update CONTRIBUTING GUIDELINES 

    Add a note on visual imperfections and viewbox problems due to 
optimizing.
    @ericcornelissen
    ericcornelissen committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    ce39f87 View commit details
    Browse the repository at this point in the history

  3. Update CONTRIBUTING.md 

    Co-authored-by: Peter Noble <PeterShaggyNoble@users.noreply.github.com>
    @ericcornelissen @PeterShaggyNoble
    ericcornelissen and PeterShaggyNoble committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    8ec4547 View commit details
    Browse the repository at this point in the history