New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Land Rover #3195
Land Rover #3195
Conversation
Thanks for taking this one on, @NovaGL 👍 I'll review the SVG in a bit but, for now, the build is failing because of the
UPDATE: Scratch that, I'm now getting the same certificate error @runxel was getting on that URL. We'll need to figure something else out 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that really is a mess! Almost as bad as the Vauxhall one - fair play to you for taking it on 👍
Other than the changes mentioned above, I'd be happy to merge this in as it is; the SVG looks great to me. It didn't quite line up with the version I came up with for comparison purposes but I suspect I may have been a bit overzealous in the number of paths I removed - I pared it down to just the 2 ovals and the wordmark. Given that, the mess the source is and that the choice of colour wasn't 100% clear, we will need one of the other @simple-icons/maintainers to throw a second eye over it anyway to double-check everything.
Done those changes as requested and linked directly to a PDF, although any of these PDFs should do. https://www.landrover.com.au/download-a-brochure/index.html After you remove all the paths some of the PDFS actually have a monochrome logo as the base, just needed a little bit of fixing. |
Thanks for that, @NovaGL I would suggest, though, https://www.landrover.com.au/download-a-brochure/index.html as the source URL. Other than that, I'm happy to merge this in pending another review. Seeing as it's still inaccessible, here's the PDF @NovaGL extracted the icon from, so you can compare like with like: |
No problem, I just was basing it off this
|
Ah, yes, sorry, I should have made that clearer: That suggestion was just for that particular PDF as we couldn't find a page anywhere that linked to it directly. Generally, though, we'd use the page a PDF was found on as the source URL. |
Run svgo again to fix the overzealous whitespace consumption of svgomg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks @NovaGL!
There are still some superfluous points in the ellipses, but thats totally okay for now.
(Disclosure: I ran svgo again to insert some whitespace back in, which svgomg sadly removes – which will make the svg unusable in Illustrator; shows up properly in browsers tho.)
Issue: Closes #3175
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Extracted and cleaned logo from PDF #3175