New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Bioconductor icon #3198
add Bioconductor icon #3198
Conversation
Welcome to Simple Icons, @schifferl and thanks for the contribution. Thanks too for pinging Bioconductor for feedback - I've added the "awaiting reply" label to this to give them a few days to review this themselves and respond before we start into our review process. The reason the build failed, by the way, is because our new linter has detected that the SVG's width slightly exceeds the canvas width but if you want to hold off on fixing that until we've heard from Bioconductor, that's fine. |
@schifferl maybe we could communicate about this 'off line' via slack or email? I'd like to understand your motivation, why one wouldn't simply make an svg logo available on the bioc web site, licensing implications, etc. |
Thanks for taking the time to respond, @mtmorgan 👍 Rest assured that should you prefer not to have your logo included in our library due to licensing concerns then we would, of course, respect those wishes. We'll leave you and @schifferl to discuss it further offline, as they are more familiar with your brand and the possible use-cases for adding Bioconductor to Simple Icons, and you can let us know the result of that discussion here. |
Thank you for the pointers @PeterShaggyNoble, and I will have bit of an 'off line' conversation to clarify with @mtmorgan. The linter issue is fixed now in my fork. Talk soon. |
After the 'off line' discussion on this pull request, I am going to close it and delete my fork. Sorry for the trouble but thank you @PeterShaggyNoble for the awesome support! Keep up the great work : ) |
That's a shame, @schifferl, but a decision we fully respect. Thanks for your efforts on both the icon and in communicating with Bioconductor. And thanks as well to @mtmorgan for taking the time to provide feedback 👍 |
Issue: Closes #3193
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
There's a line about "consider adding a preview image of your submission" and I'm not sure where that goes, so it's attached. As for approval, @mtmorgan (the head of Bioconductor) is the person to ask and can probably give it quickly.
Hex code is
#1A81C2
because it comprises more of the logo. The logo was already a vector and simply the text was removed. It will be useful for status badges in the future. Please let me know if anything else is needed.