-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Drooble icon #3231
Add Drooble icon #3231
Conversation
Merge changes
Pull latest version
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Okay, they are indeed in the middle of rebranding. Their new logo is the one in which I derived the icon from, so we're good to go. |
Thanks for reaching out to them, @bhadaway; that's a big help 👍 Normally, I would suggest holding off on a newly rebranded logo until such a time as the rebranding is complete but as the only place they haven't rolled it out yet is on their website, I think we can proceed with this one. |
D'oh! Forgot to actually review this! 🙄 I am noticing some inconsistencies but, as proven in the past, I'm pretty bad at comparing raster to vector so I've requested reviews from a couple of the other @simple-icons/maintainers. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Done. Official AI: https://calmestghost.com/drooble.ai Updated SVG: https://calmestghost.com/drooble.svg Correct Brand Color: |
Many thanks for reaching out, @bhadaway 👍 |
You're welcome. |
Co-Authored-By: Bryan Hadaway <bhadaway@gmail.com>
Thanks for the new source material @bhadaway, this looks good to me now. I took the liberty of updating the PR using your SVG as a basis. Since I did that I'll leave it to another @simple-icons/maintainers to have a look at this and merge it in 😃 |
The new SVG is slightly off vertical centre; Inkscape shows it sitting at |
Good thing I left it open for review, didn't check carefully enough after optimization 🙃 Before I push an update, how is the version below (precision 4 instead of 3): <svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Drooble icon</title><path d="M12.001 9.998c1.104 0 2 .896 2 2s-.896 2-2 2-2-.896-2-2 .895-2 2-2zm11.998 2C24 8.036 20.951 4.742 17 4.439v7.559c.002 2.762-2.235 5-4.997 5.001-2.76.002-5-2.234-5.001-4.995-.001-2.762 2.235-5.001 4.997-5.002.688 0 1.37.142 2.002.417V.17C7.467-.935 1.275 3.467.171 10c-1.104 6.534 3.297 12.726 9.83 13.83 6.534 1.105 12.726-3.296 13.83-9.83.111-.661.168-1.331.168-2.002z"/></svg> |
Just wanted to jump in one last time to make sure you're using the latest version (because @ericcornelissen's reply has the wrong code). You want:
I'm sure it's still not perfect though; is that even possible; do all the other icons in the set perfectly match their official logo? It seems like you would have to take some liberties to bend them to the will of the icon set, no? Anyway, I'll leave it to the official contributors now, thanks for taking my suggestion, and it's an interesting process. At a later time, I may decide to properly clone the repo and get involved in a more meaningful way. https://simpleicons.org/ has been a very vital tool in my arsenal for a while now. I jumped from one icon font to another, to premium SVG sets, blah blah blah, until finally finding something that stuck, with Simple Icons. Thanks |
@bhadaway I used the
In general, if there is an official vector source then that should be possible. And @PeterShaggyNoble compared my SVG to your SVG, which should match. |
There are very tiny differences between the two SVGs, I believe it's good enough to be merged. |
With our new linting step, the build was failing on the previous version of the SVG. Upping the precision to 3 seems to solve all the issues so I've pushed an updated path using that (hope you don't mind, @NovaGL). |
no problem. Sorry for being awol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's all looking good now, thanks for the efforts @NovaGL @bhadaway, and @PeterShaggyNoble 🎉
Yay, teamwork! 🎉 Thanks, everyone, for your collaborative efforts on this one. |
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
@bhadaway manually converted the raster logo to vector from their Google Drive
Closes #3229