Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Drooble icon #3231

Merged
merged 16 commits into from
Jul 10, 2020
Merged

Add Drooble icon #3231

merged 16 commits into from
Jul 10, 2020

Conversation

NovaGL
Copy link
Contributor

@NovaGL NovaGL commented Jun 19, 2020

droobble

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@bhadaway manually converted the raster logo to vector from their Google Drive

Closes #3229

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Jun 19, 2020
@PeterShaggyNoble

This comment has been minimized.

@PeterShaggyNoble PeterShaggyNoble added the in discussion There is an ongoing discussion that should be finished before we can continue label Jun 22, 2020
@NovaGL

This comment has been minimized.

@bhadaway

This comment has been minimized.

@bhadaway
Copy link
Contributor

Okay, they are indeed in the middle of rebranding.

Their new logo is the one in which I derived the icon from, so we're good to go.

@PeterShaggyNoble
Copy link
Member

Thanks for reaching out to them, @bhadaway; that's a big help 👍

Normally, I would suggest holding off on a newly rebranded logo until such a time as the rebranding is complete but as the only place they haven't rolled it out yet is on their website, I think we can proceed with this one.

@PeterShaggyNoble PeterShaggyNoble removed the in discussion There is an ongoing discussion that should be finished before we can continue label Jun 22, 2020
@PeterShaggyNoble
Copy link
Member

D'oh! Forgot to actually review this! 🙄

I am noticing some inconsistencies but, as proven in the past, I'm pretty bad at comparing raster to vector so I've requested reviews from a couple of the other @simple-icons/maintainers.

@bhadaway

This comment has been minimized.

@ericcornelissen

This comment has been minimized.

@bhadaway

This comment has been minimized.

@bhadaway
Copy link
Contributor

Done.

Official AI: https://calmestghost.com/drooble.ai

Updated SVG: https://calmestghost.com/drooble.svg

Correct Brand Color: #19c4be

@PeterShaggyNoble
Copy link
Member

Many thanks for reaching out, @bhadaway 👍

@bhadaway
Copy link
Contributor

You're welcome.

Co-Authored-By: Bryan Hadaway <bhadaway@gmail.com>
@ericcornelissen
Copy link
Contributor

Thanks for the new source material @bhadaway, this looks good to me now. I took the liberty of updating the PR using your SVG as a basis. Since I did that I'll leave it to another @simple-icons/maintainers to have a look at this and merge it in 😃

@PeterShaggyNoble
Copy link
Member

The new SVG is slightly off vertical centre; Inkscape shows it sitting at 0.002 on the Y axis, rather than 0. After fixing that, though, I'm seeing a couple of hairline differences (see examples in screenshots below, with @bhadaway's version in red). Both issues are probably just a result of the precision being too low, though.


@ericcornelissen
Copy link
Contributor

Good thing I left it open for review, didn't check carefully enough after optimization 🙃

Before I push an update, how is the version below (precision 4 instead of 3):

<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Drooble icon</title><path d="M12.001 9.998c1.104 0 2 .896 2 2s-.896 2-2 2-2-.896-2-2 .895-2 2-2zm11.998 2C24 8.036 20.951 4.742 17 4.439v7.559c.002 2.762-2.235 5-4.997 5.001-2.76.002-5-2.234-5.001-4.995-.001-2.762 2.235-5.001 4.997-5.002.688 0 1.37.142 2.002.417V.17C7.467-.935 1.275 3.467.171 10c-1.104 6.534 3.297 12.726 9.83 13.83 6.534 1.105 12.726-3.296 13.83-9.83.111-.661.168-1.331.168-2.002z"/></svg>

@bhadaway
Copy link
Contributor

bhadaway commented Jul 3, 2020

Just wanted to jump in one last time to make sure you're using the latest version (because @ericcornelissen's reply has the wrong code). You want:

<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Drooble icon</title><path d="m12 10a2 2 0 1 1 -2 2 2 2 0 0 1 2-2zm12 2a7.58 7.58 0 0 0 -7-7.56v7.56a5 5 0 1 1 -3-4.58v-7.25a12 12 0 1 0 10 11.83z"/></svg>

I'm sure it's still not perfect though; is that even possible; do all the other icons in the set perfectly match their official logo? It seems like you would have to take some liberties to bend them to the will of the icon set, no?

Anyway, I'll leave it to the official contributors now, thanks for taking my suggestion, and it's an interesting process. At a later time, I may decide to properly clone the repo and get involved in a more meaningful way.

https://simpleicons.org/ has been a very vital tool in my arsenal for a while now. I jumped from one icon font to another, to premium SVG sets, blah blah blah, until finally finding something that stuck, with Simple Icons.

Thanks

@ericcornelissen
Copy link
Contributor

@bhadaway I used the .ai file as a basis. I recal that I had to move it a bit, and I also optimized it (again?) using the SVGO CLI. Thanks for sharing your version as well, though. (I currently am not able to compare it)

I'm sure it's still not perfect though; is that even possible; do all the other icons in the set perfectly match their official logo? It seems like you would have to take some liberties to bend them to the will of the icon set, no?

In general, if there is an official vector source then that should be possible. And @PeterShaggyNoble compared my SVG to your SVG, which should match.

@NovaGL
Copy link
Contributor Author

NovaGL commented Jul 5, 2020

There are very tiny differences between the two SVGs, I believe it's good enough to be merged.

@PeterShaggyNoble
Copy link
Member

With our new linting step, the build was failing on the previous version of the SVG. Upping the precision to 3 seems to solve all the issues so I've pushed an updated path using that (hope you don't mind, @NovaGL).

@NovaGL
Copy link
Contributor Author

NovaGL commented Jul 10, 2020

no problem. Sorry for being awol

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all looking good now, thanks for the efforts @NovaGL @bhadaway, and @PeterShaggyNoble 🎉

@ericcornelissen ericcornelissen merged commit bd9738c into simple-icons:develop Jul 10, 2020
@PeterShaggyNoble
Copy link
Member

Yay, teamwork! 🎉 Thanks, everyone, for your collaborative efforts on this one.

github-actions bot added a commit that referenced this pull request Jul 14, 2020
# New Icons

- Drooble (#3231)
- IFTTT (#3304)
- JPEG (#3303)
- Planet (#3274)

# Updated Icons

- Ardour (#3256)
- Basecamp (#3277)
- Celery (#3256)
- CentOS (#3256)
- Cloudsmith (#3256)
- deepin (#3256)
- JetBrains (#3256)
- KTM (#3256)
- Nucleo (#3285)
- uBlock Origin (#3256)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drooble
4 participants