Add Photobucket

[HanselD]

Issue: Closes #3213
Alexa rank: 3896

Checklist

• I updated the JSON data in _data/simple-icons.json
• I optimized the icon with SVGO or SVGOMG
• The SVG viewbox is 0 0 24 24

Description

I picked the hex value per @PeterShaggyNoble's suggestion on the issue. The blue definitely seems to be their primary color. I was not able to find a brand/style guide so I picked the image from their header.

[PeterShaggyNoble]

Thanks for the contribution, @HanselD 👍

It looks like you managed to vertically stretch the path with this commit, the version in this commit was spot on. Although, it was 24.001 in width, rather than the expected 24, which should have been caught by the changes in #3107 🤔 (pinging @davidjb for investigation)

[davidjb]

@PeterShaggyNoble The linter in #3107 doesn't have a degree of tolerance. It has a precision of 3 which has the effect of resolving rounding errors in float representations (e.g. if the number was 24.00000000000001 or 23.99999999992 they get resolved to "24.000" which becomes 24). If the computed size was say 24.00119999999 or any number greater than 24.0005 and less than 24.0015 - including if it happened to actually be 24.001 exactly - then these sizes resolve to be 24.001.

The other discussion in the PR over in #3250 is talking about allowing a tolerance of 0.001 for centring, so that could be applied to the size linter as well if implemented.

[HanselD]

Hi @PeterShaggyNoble , happy to roll it back to this commit. I think the issue was I used IcoMoon first and the lint checks weren't passing. I switched to Inkscape which worked better. Let me know!

[PeterShaggyNoble]

@HanselD, if you could roll back to that commit, please, then this should be good to go.

a tolerance of 0.001 ... could be applied to the size linter as well if implemented.

I don't think we should apply that variance to the size linter, @davidjb as the main reason for it was to catch icons with one or both of its dimensions being 24.001, as that was the most common issue.

[HanselD]

Rolled back! Please let me know if this is good to go

[PeterShaggyNoble]

Thanks for that, @HanselD

You've managed to remove package-lock.json and package.json from your branch, though - could you restore them, please?

On the SVG, it's still coming in at 24.001 wide, which can usually be rectified by increasing the precision by 1 when optimising it.

[HanselD]

@PeterShaggyNoble Re-added pkg-lock and resized the image. I think I've got it right this time, please let me know!

[PeterShaggyNoble]

Looks like something's gone awry, @HanselD - it's gone back to the vertically stretched version.

[HanselD]

Sorry about that, I really have no idea what I'm doing wrong here. I'll start over and update later this week.
Just curious, where do you see the vertically stretched version? I'm confused about how the build is passing despite that.

[ericcornelissen]

Sorry about that, I really have no idea what I'm doing wrong here. I'll start over and update later this week.

No problem. If you're having trouble working with git, feel free to ask us for help. Regarding the icon, I'm not sure how you're editing this but the vertical stretching could be a result of manually editing the SVG. Make sure to get the icon looking good in a 24x24 canvas in your editing software and don't touch the SVG yourself after that. I hope that helps 😄

Just curious, where do you see the vertically stretched version? I'm confused about how the build is passing despite that.

We are unable to check this in the build as it is a purely visual feature of the icon that is different from icon to icon. You can see it simply by viewing the SVG (e.g. in your browser). If you do that you will see that it looks taller then it's supposed to be.

[PeterShaggyNoble]

Are you still working on this, @HanselD?

[adamrusted]

Updated source to Photobucket homepage, and rebuilt from source SVG found embedded in header.
Can another @simple-icons/maintainers check c06af82 over and merge if it's okay?

[mondeja]

LGTM @adamrusted 👍
Thank you for the previous work @HanselD! 🙏