Remove extraneous spaces from icon markup

[PeterShaggyNoble]

Issue: Fixes #3247
Alexa rank: n/a

Checklist

• I updated the JSON data in _data/simple-icons.json
• I optimized the icon with SVGO or SVGOMG
• The SVG viewbox is 0 0 24 24

Description

Removes spaces

• before the > in the opening svg tag in ardour.svg, centos.svg & cloudsmith.svg,
• between the role attribute and its = in the opening svg tag in jetbrains.svg, and,
• before the closing / in the path tag in celery.svg, deepin.svg ktm.svg & ublockorigin.svg.

[ericcornelissen]

These changes are fine by me. Are we not going to lint for these kind of issues until they can be automatically fixed?

[PeterShaggyNoble]

Depends how far out we are from implementing #2380 - SVGO will strip away any excess whitespace for us.

[ericcornelissen]

Depends how far out we are from implementing #2380 - SVGO will strip away any excess whitespace for us.

Since we need to create a Probot for that, not for as I don't think anyone started doing that yet.

[PeterShaggyNoble]

OK, I've updated the RegEx you added in #3239 with the one I suggested in #3247 and reworded the related error message accordingly.

Build passed

[ericcornelissen]

I'm personally OK with enforcing this even though we do not (yet) automatically fix those. Still, I would like at least one other @simple-icons/maintainers to accept this before we merge this in because of that.

The error message is fine by me, but I expect there will be some instances where a contributor gets confused by it. I think it's best if we update the error message based on feedback in such instances.

[runxel]

Consistency is always good :)
And the PR looks good to me so I will gladly merge this in. Thank you for the work @PeterShaggyNoble, and of course for detecting this in the first place. 👍