Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Apache #4294

Merged
merged 1 commit into from Dec 8, 2020
Merged

Correct Apache #4294

merged 1 commit into from Dec 8, 2020

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Dec 8, 2020

apache

Issue: #2887
Alexa rank: n/a

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The Apache icon looks incorrect, so I've corrected. This is the comparison between the Apache press-kit icon and the current one in simple-icons:

apache-main-update

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Dec 8, 2020
@mondeja mondeja mentioned this pull request Dec 8, 2020
17 tasks
@fbernhart
Copy link
Contributor

LGTM! 👍🏼

According to their guidelines it seems like we unfortunately need to add the TM symbol.

The appropriate trademark symbol(s), such as ® or ™, associated with the project's logo must be included in the logo;

@mondeja
Copy link
Member Author

mondeja commented Dec 8, 2020

Feel free to do the merge if you see it right @fbernhart, but does not forget to select the option "Squash and merge" in the "Merge pull request" button 👀

@fbernhart
Copy link
Contributor

@mondeja Ok, let me try to do my first GitHub merge ever! 😲

But don't blame me, if the whole internet stops working afterwards. 😂

@fbernhart fbernhart merged commit 6f7c1f5 into simple-icons:develop Dec 8, 2020
@mondeja
Copy link
Member Author

mondeja commented Dec 8, 2020

My house is on fire now 🏠 🔥 😮

Nah, we survived this one. Thanks for the merge @fbernhart!

@mondeja mondeja deleted the apache branch December 10, 2020 08:42
ericcornelissen added a commit that referenced this pull request Dec 13, 2020
# New Icons

- diagrams.net (#4310)
- Hack The Box (#4254)
- National Grid (#3633)
- Snowflake (#4089)
- Tutanota (#3375)

# Updated Icons

- Airbus (#3962)
- Anaconda (#3965)
- Apache (#4294, #3967)
- Apache OpenOffice (#3969)
- Audiomack (#3981)
- Bamboo (#3992)
- CRYENGINE (#3894)
- Eleventy (#3897)
- ESEA (#3898)
- Evernote (#3899)
- EyeEm (#3900)
- Google My Business (#3901)
- Gutenberg (#3904)
- HelloFresh (#3907)
- Humble Bundle (#4071)
- Livestream (#3913)
- McAfee (#4100)
- MicroStrategy (#4104)
- Minds (#4105)
- NEC (#4107)
- Nextdoor (#4110)
- NFC (#4111)
- Nim (#3923)
- NuGet (#4113)
- Platzi (#4169)
- Reason Studios (#4180)
- Salesforce (#4185)
- SketchUp (#4311)
- SlideShare (#3939)
- Steem (#4201)
- Steinberg (#4203)
- Stylus (#4215)
- Svelte (#4218)
- XFCE (#4241)
- YouTube Music (#4246)
- Zalando (#3947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants