Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Apache NetBeans IDE #4421

Merged
merged 6 commits into from Dec 21, 2020
Merged

Updated Apache NetBeans IDE #4421

merged 6 commits into from Dec 21, 2020

Conversation

adamrusted
Copy link
Member

apachenetbeanside (3)

Issue: Contributes toward #2887
Fixes #3714
Alexa rank: N/A

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Path generated in Adobe Illustrator, using source SVG for reference.
Ran through SVGO CLI and SVGlint.

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Dec 21, 2020
@adamrusted adamrusted mentioned this pull request Dec 21, 2020
17 tasks
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing strange imperfections in the corners. Seems that these also exists in previous version currently available in simple-icons. Could you rebuild from source @adamrusted?

Looks like the imperfections are coming when I combine the individual paths for the lines into a combined object. Will try a different way now.

@adamrusted
Copy link
Member Author

Whoops! I edited your comment instead of quoting it....

@adamrusted
Copy link
Member Author

@mondeja - give this new path a go. It's not the neatest, but should give us correct geometry.

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The geometry looks spot on now, however I'm seeing a lot of weird coordinates in the intersections. Seems that there are inneficient knots in these places... Could you check that?

image

_data/simple-icons.json Outdated Show resolved Hide resolved
Adam and others added 2 commits December 21, 2020 19:35
Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
@adamrusted
Copy link
Member Author

@mondeja - had to export with a precision of 4 to get the correct dimensions.

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, perfect! 👍
Just one small change. I have been able to remove these 6 coordinates without altering the result, could you remove them?

image

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 💯
Thank you @adamrusted 🙃

@mondeja mondeja merged commit f8f5ff1 into simple-icons:develop Dec 21, 2020
@adamrusted adamrusted deleted the apachenetbeans branch December 21, 2020 20:05
ericcornelissen added a commit that referenced this pull request Dec 27, 2020
# New Icons

- Apache Tomcat (#4154)
- Blazemeter (#4385)
- Cocos (#4340)
- Delphi (#4139)
- DoorDash (#4094)
- GitBook (#3975)
- Informatica (#4142)
- Jaguar (#4267)
- Max-Planck-Gesellschaft (#3793)
- MeWe (#4268)
- ngrok (#3949)
- Packagist (#4390)
- PCGamingWiki (#3664)
- Pro Tools (#3880)
- SingleStore (#4451)
- Spyder IDE (#4092)
- Thymeleaf (#4411)
- Triller (#4384)
- TryHackMe (#4258)

# Updated Icons

- Academia (#4449)
- Adobe InDesign (#4460)
- AirPlay Audio (#3963)
- Amazon Lumberyard (#3964)
- AngelList (#3966)
- Apache NetBeans IDE (#4421)
- Apple Pay (#3972)
- AT&amp;T (#3980)
- AT&T (#3980)
- Azure Functions (#3983)
- Baidu (#3984)
- Beats (#3995)
- Beats by Dre (#3996)
- Behance (#3997)
- Boeing (#4000)
- Buffer (#4004)
- CD Projekt (#4432)
- Cinema 4D (#4005)
- Cirrus CI (#4006)
- CloudBees (#4007)
- CodeChef (#4009)
- CodeIgniter (#4010)
- Codeship (#4011)
- Codewars (#4012)
- Common Workflow Language (#4013)
- ComproPago (#4015)
- Corona Engine (#4454)
- Craft CMS (#4144)
- CSS Wizardry (#4017)
- Dassault Systèmes (#4019)
- DataCamp (#4455)
- Datadog (#4020)
- dblp (#4021)
- Diaspora (#4023)
- DLNA (#4025)
- Draugiem.lv (#4026)
- Elastic Cloud (#4031)
- Electron (#4034)
- Elixir (#4035)
- Envato (#4038)
- Eventbrite (#4039)
- Ferrari N.V. (#4456)
- FileZilla (#4048)
- freedesktop.org (#4049)
- Garmin (#4445)
- Genius (#4050)
- Gitea (#4052)
- GitHub Sponsors (#4457)
- Gitpod (#4441)
- Glitch (#4053)
- GNU IceCat (#4054)
- GoldenLine (#4056)
- Goodreads (#4057)
- Google Nearby (#4059)
- Grafana (#4062)
- Gumtree (#4064)
- HackerEarth (#4065)
- Haskell (#4066)
- Helm (#4067)
- HERE (#4068)
- Hexo (#4069)
- homify (#4070)
- iCloud (#4073)
- ICON (#4074)
- ICQ (#4075)
- Indeed (#4076)
- JetBrains (#4347)
- Jinja (#4078)
- KaiOS (#4079)
- Kentico (#4080)
- Keybase (#4081)
- Kibana (#4082)
- Last.fm (#4083)
- LeetCode (#4084)
- LibraryThing (#4085)
- LLVM (#4088)
- Mendeley (#4102)
- Mix (#3921)
- Mojang Studios (#4288)
- Notist (#4112)
- Nutanix (#4114)
- Opel (#4431)
- Open Collective (#4160)
- Overleaf (#4162)
- Palo Alto Software (#4163)
- Pi-hole (#4167)
- Prismic (#4171)
- protocols.io (#4172)
- ProtonMail (#4173)
- PureScript (#4174)
- Quarkus (#4175)
- React (#4430)
- Realm (#3930)
- Scrutinizer CI (#3935)
- Slackware (#3938)
- StackPath (#4198)
- Topcoder (#4226)
- Tor Project (#4248)
- TrainerRoad (#4227)
- Treehouse (#4228)
- Udacity (#4229)
- Vagrant (#4230)
- Veeam (#4231)
- Wattpad (#4290)
- webcomponents.org (#4234)
- WeChat (#4236)
- Windows 95 (#4237)
- XAML (#4240)
- Yelp (#4242)
- Zulip (#4255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netbeans icon lines too thin
2 participants