Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Apache Cordova #4422

Closed
wants to merge 1 commit into from
Closed

Update Apache Cordova #4422

wants to merge 1 commit into from

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Dec 21, 2020

apachecordova

Issue: #2887
Alexa rank: n/a

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Updated logo using https://apache.org/logos/ as source.

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Dec 21, 2020
@mondeja mondeja mentioned this pull request Dec 21, 2020
Closed
17 tasks
adamrusted
adamrusted reviewed Dec 21, 2020
View reviewed changes
icons/apachecordova.svg
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Apache Cordova icon</title><path d="M9.276 13.302c0 1.193-.273 2.16-.61 2.16-.336 0-.61-.967-.61-2.16 0-1.194.274-2.162.61-2.162.337 0 .61.968.61 2.162zM5.463.532L0 9.308l2.234 14.16h3.84l-.313-3.29h1.972l.25 3.29h8.047l.25-3.29h1.96l-.315 3.29h3.866L24 9.31 18.51.53zm8.473 4.38h3.53v.003h.03l2.153 4.394-1.103 8.704H5.49L4.398 9.308l2.155-4.35h3.543l-.26 1.572h4.325zm2.235 8.085c0 1.193-.272 2.16-.61 2.16-.336 0-.61-.967-.61-2.16.002-1.194.274-2.162.61-2.162.338 0 .61.968.61 2.162z"/></svg>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming reverting to old source - there seem to be differences in the path.
image

Path I've used (from master) for comparison

M18.545,0.545H5.455L0,9.273l2.182,14.182h3.886l-0.273-3.273h1.909l0.273,3.273h8.045l0.273-3.273h1.909 l-0.273,3.273h3.886L24,9.273L18.545,0.545z M18.545,18H5.455L4.364,9.273l2.182-4.364h3.506L9.818,6.545h4.364l-0.234-1.636h3.506 l2.182,4.364L18.545,18z M16.091,13.075c0,1.121-0.244,2.029-0.545,2.029c-0.301,0-0.545-0.908-0.545-2.029 c0-1.121,0.244-2.029,0.545-2.029C15.847,11.045,16.091,11.954,16.091,13.075z M9.205,13.244c0,1.121-0.244,2.029-0.545,2.029 c-0.301,0-0.545-0.908-0.545-2.029c0-1.121,0.244-2.029,0.545-2.029C8.96,11.215,9.205,12.123,9.205,13.244z

@mondeja
Copy link
Member Author

mondeja commented Dec 21, 2020

🤔 Unfortunately, I'm not able to work with .psd files, so I'm closing this. Maybe someone else can take care of it. It's a bit weird that Apache uses privative software to share their vectors, taking into account their licenses.

@mondeja mondeja closed this Dec 21, 2020
@mondeja mondeja added the abandoned Pull requests that have been abandoned by the contributor label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted left review comments

Assignees
No one assigned
Labels
abandoned Pull requests that have been abandoned by the contributor update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mondeja @adamrusted