New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Google Ads #4471
Updated Google Ads #4471
Conversation
The SVG looks perfect to me, @adamrusted. However, it should be noted that the monochrome treatment mentioned here is still in use on Google My Business so I think we should stick with that. What do the other @simple-icons/maintainers think? |
Conversely, adding the cut-out makes it consistent with other Google icons such as AdSense & Optimize. Also, per this comment, should the cut-out here also be 0.5dp? |
Yep - I think a lot of these Google ones were prior to the 0.5px discussion. I'll have a look over these today. |
@PeterShaggyNoble should be sorted. |
Before reviewing, do any of the other @simple-icons/maintainers have any opinions on whether or not we should stick with our current treatment (per this comment) or add the cut-out to make it consistent with other, similar Google icons (per this comment)? |
That is a good question! |
Though I agree that an official is preferred, I'm not sure if an icon from a different Google service that is arguably very much different from the actual logo can be considered official. I don't recall any specific incidents, but I definitely remember Google forgetting to update logos of product A in product B 🤔 |
Well, this is odd, the SVG is passing the linter but, when I pull it into Inkspace, it's showing as Here's my own attempt at it:
|
Yeah - I'm not able to pass the linter at all with the path above, and seem to remember I had some trouble with this one. Figured if the linter passed we were good to go! 😅 |
Got it passing with 4 decimals of precision. Not ideal, but if it gets it through the linter 🤷🏻♂️ |
Sorry, @adamrusted; forgot about this one 🤦🏻♂️ Looks good to me now; thanks for your continued work on it 👍🏻 |
# New Icons - Amazon S3 (#4999) - Commerzbank (#5028) - DatoCMS (#5184) - Enpass (#5174) - Hyper (#5197) - Mercurial (#5157) - Pointy (#4952) - Private Internet Access (#5158) - Stimulus (#5209) - SymPy (#4554) - XState (#4971) # Updated Icons - AlliedModders (#5107) - Code Climate (#5194) - Elsevier (#5175) - Firefox (#5203) - Git (#5213) - Google Ads (#4471) - Monzo (#5219) - Notepad++ (#5187) - pre-commit (#5226) - SparkFun (#5196) - Stack Overflow (#5217)
Issue: Contributes to #4205
Alexa rank: N/A
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Source updated as per comment.
Rebuilt from source, with 0.35px line between colour changes.