Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cocos #4528

Closed
wants to merge 4 commits into from
Closed

Remove Cocos #4528

wants to merge 4 commits into from

Conversation

adamrusted
Copy link
Member

@adamrusted adamrusted commented Dec 29, 2020

See #2127, #4340
Remove Cocos logo following discussion with Marketing Director.
Designer does not want logo altered in any way, including removing / changing colors - therefore we're unable to use the monochrome version generated.

@adamrusted adamrusted added out of scope Issues or pull requests that are beyond the scope of the project breaking change Issues or pull requests that include a breaking change and scheduled for the next major release labels Dec 29, 2020
@adamrusted adamrusted added this to the v5.0.0 milestone Dec 29, 2020
@mondeja mondeja mentioned this pull request Jan 3, 2021
69 tasks
@PeterShaggyNoble
Copy link
Member

Just to clarify: from Luke's comments it seems to me that a monochrome treatment is allowed but only in white - both our existing and new websites would violate that as both display it in black.

@adamrusted
Copy link
Member Author

adamrusted commented Jan 11, 2021

@PeterShaggyNoble yep - and because they don't have documented brand guidelines online, we're unable to advise our users when #2846 is resolved.

@PeterShaggyNoble
Copy link
Member

If that's our only concern then we could, instead, link directly to Luke's comment regarding white being the only acceptable colour.

@adamrusted
Copy link
Member Author

If that's our only concern then we could, instead, link directly to Luke's comment regarding white being the only acceptable colour.

Could do, though that'd require the 'brand guidelines' Issue / PR to be resolved first.

@adamrusted adamrusted marked this pull request as ready for review May 24, 2021 07:30
@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented May 24, 2021

Let's ping @CocosLuke for final say on this one before removing it. Our new website's dark theme would display your icon in white although it would be black in the light theme. But, if we were to link to your comment stating that the icon can only be used in white, would you be happy for us to keep it. Obviously, even with that link in place, it would be impossible for us to actually enforce what colour our users display your icon in.

If either of those things are an issue for you then we will, of course, respect your wishes and this PR can be merged straight in once the conflicts are resolved.

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label May 24, 2021
@PeterShaggyNoble
Copy link
Member

Closing this out due to us now having full approval.

@PeterShaggyNoble PeterShaggyNoble added abandoned Pull requests that have been abandoned by the contributor and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed out of scope Issues or pull requests that are beyond the scope of the project labels May 25, 2021
@adamrusted adamrusted deleted the AR-Remove-Cocos branch August 30, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned Pull requests that have been abandoned by the contributor breaking change Issues or pull requests that include a breaking change and scheduled for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants