Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Livestream #4647

Merged
merged 4 commits into from
May 24, 2021
Merged

Remove Livestream #4647

merged 4 commits into from
May 24, 2021

Conversation

fbernhart
Copy link
Contributor

@fbernhart fbernhart commented Jan 6, 2021

Issue: Contributes to #4590
Alexa rank: 9,442

Checklist

- [x] I updated the JSON data in _data/simple-icons.json
- [x] I optimized the icon with SVGO or SVGOMG
- [x] The SVG viewbox is 0 0 24 24

Description

- Seems like Livestream has been bought by vimeo back in 2017. See their blog and Wikipedia
- The new logo is a combination of the vimeo and livestream wordmark.
- SVG pulled from the header of https://livestream.com
- Changed source to https://livestream.com, as https://livestream.com/press doesn't exist anymore.
- Changed color to #000000. The SVG at source doesn't have a color, so black is probably the best choice.

Edit

This PR removes Livestream as the brand doesn't exist anymore. It's now called "Vimeo Livestream" and has a different logo. "Vimeo Livestream" is added in a different PR.

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jan 6, 2021
@fbernhart
Copy link
Contributor Author

fbernhart commented Jan 6, 2021

Seems like Livestream has been bought by vimeo back in 2017. See their blog and Wikipedia

@simple-icons/maintainers I've been wondering if we should as well rename this one (which would be a breaking change). I have the impression that Vimeo Livestream would be a better fit than just Livestream. Their Twitter account for example is as well called Vimeo Livestream now.

Any opinions?

Another option would be to actually just fix the collinear linter error of the old icon, creating a new icon called Vimeo Livestream and then removing Livestream with the next major release.

@fbernhart fbernhart added the in discussion There is an ongoing discussion that should be finished before we can continue label Jan 6, 2021
@fbernhart fbernhart mentioned this pull request Jan 6, 2021
69 tasks
@ericcornelissen
Copy link
Contributor

I agree @fbernhart, either

Another option would be to actually just fix the collinear linter error of the old icon, creating a new icon called Vimeo Livestream and then removing Livestream with the next major release.

Or we update the icon under the current name and rename with the next release 👍

@PeterShaggyNoble
Copy link
Member

I don't think this is the right way to go on either front. In the absence of a colour in the source icon (or brand guidelines where available), we should go with our best guess from the website. In this case I'd say it should be either the purple #0a0a20 that features throughout the site and in their favicon on the homepage.

However, and more pressingly, I don't think we need to use the full wordmark here as they themselves use the Vimeo "V" in a few places, including in the favicon and in the website's header when you scale down to smaller sizes. Given that and, as we've yet to fully resolve #3270 & #3219, I'd hold off on doing anything for now as the solution may end up being to remove this completely.

Or we update the icon under the current name and rename with the next release

If it's decided that we're going to allow brands that share an icon with another one then this would also be my preferred approach, too, to avoid duplication.

@ericcornelissen
Copy link
Contributor

If it's decided that we're going to allow brands that share an icon with another one then this would also be my preferred approach, too, to avoid duplication.

To me, the discussion here is a separate from #3270. There we consider icons that will be part of the collection "permanently" using the same icon. Here, we consider the option of providing the icon of a renamed brand in two ways in one version so as to make upgrading to the next major version potentially easier. That does not mean I think we should necessarily provide both icons, I just want to point out that these are two different scenarios.

Now, from a user's perspective, I would say it is ideal to have both "Livestream" and "Vimeo Livestream" available in v4, and remove "Livestream" when v5 comes around. This is because 1) it gives users of "Livestream" a larger window of time to update and 2) it allows users looking for "Vimeo Livestream" to find it already in v4. (This is arguably not as big a deal for "Vimeo Livestream" as it still contains the old name, but e.g. the rename from Postwoman to Hopscotch would be more relevant to this argument.)


I won't respond to the rest of the discussion, at least for now

@PeterShaggyNoble
Copy link
Member

To clarify: my reference to #3270 was in direct relation to my suggestion that their icon is now just the Vimeo "V".

@adamrusted
Copy link
Member

I would say it is ideal to have both "Livestream" and "Vimeo Livestream" available in v4, and remove "Livestream" when v5 comes around. This is because 1) it gives users of "Livestream" a larger window of time to update and 2) it allows users looking for "Vimeo Livestream" to find it already in v4.

I agree with @ericcornelissen's comments above. I'd prefer to have both Livestream and Vimeo Livestream available in v4 (even if it's a duplication of this newer icon) to update the brand, and give any users of livestream.svg time to swap over to the newer icon, before the deletion of livestream.svg in v5.0.0.

@fbernhart
Copy link
Contributor Author

Ok 👍🏼 Let me make this one the "Remove Livestream" PR, that will remove livestream.svg with the next major release.

I'll as well create a new PR with "Add Vimeo Livestream".

@fbernhart fbernhart changed the title Update Livestream Remove Livestream Jan 10, 2021
@fbernhart fbernhart added breaking change Issues or pull requests that include a breaking change and scheduled for the next major release and removed in discussion There is an ongoing discussion that should be finished before we can continue labels Jan 10, 2021
@fbernhart fbernhart added this to the v5.0.0 milestone Jan 10, 2021
@fbernhart fbernhart marked this pull request as draft January 10, 2021 01:12
@fbernhart fbernhart mentioned this pull request Jan 10, 2021
3 tasks
@ericcornelissen ericcornelissen marked this pull request as ready for review May 23, 2021 18:11
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻 Once the conflicts are resolved then this can be merged straight in.

…into livestream

� Conflicts:
�	.svglint-ignored.json
@fbernhart fbernhart merged commit 1631866 into simple-icons:develop May 24, 2021
@fbernhart fbernhart deleted the livestream branch May 24, 2021 13:52
ericcornelissen added a commit that referenced this pull request May 30, 2021
# Miscellanous

- Add a `DISCLAIMER.md` (#4912)

# NPM Package

- Removed possibility to `simpleIcons.get` an icon by the brand name (#4920)
- You should now start using `simpleIcons.Get` instead of `simpleIcons.get` (#5777)

# New Icons

- GoDaddy (#5773)
- Microsoft Bing (#4744), previously "Bing"
- Replit (#5730), previously "repl.it"
- smash.gg (#5728)
- TietoEVRY (#5685), previously "EVRY"
- Web3.js (#5682)
- WEBTOON (#5381), previously "LINE WEBTOON"

# Updated Icons

- Hulu (#5774)
- Microsoft Azure (#5745)
- Nucleo (#5749)

# Updated Slugs

- .NET (#5611), from "dot-net" to "dotnet"
- A-Frame (#5611), from "a-frame" to "aframe"
- About.me (#5611), from "about-dot-me" to "aboutdotme"
- Alibaba.com (#5611), from "alibaba-dot-com" to "aboutdotme'
- AT&T (#5611), from "at-and-t" to "atandt"
- Audio-Technica (#5611), from "audio-technica" to "audiotechnica"
- B&R Automation (#5611), "b-and-rautomation" to "bandrautomation"
- Battle.net (#5611), from "battle-dot-net" to "battledotnet"
- Blockchain.com (#5611), from "blockchain-dot-com" to "blockchaindotcom"
- Chart.js (#5611), from "chart-dot-js" to "chartdotjs"
- Co-op (#5611), from "co-op" to "coop"
- Conda-Forge (#5611), from "conda-forge" to "condaforge"
- Counter-Strike (#5611), from "counter-srike" to "counterstrike"
- D-Wave Systems (#5611), from "d-wavesystems" to "dwavesystems"
- D3.js (#5611), from "d3-dot-js" to "d3dotjs"
- dev.to (#5611), from "dev-dot-to" to "devdotto"
- diagrams.net (#5611), from "diagrams-dot-net" to "diagramsdotnet"
- Digi-Key Electronics (#5611), from "digi-eyelectronics" to "digikeyelectronics"
- Draugiem.lv (#5611), from "draugiem-dot-lv" to "draugiumdotlv"
- Eclipse Vert.x (#5611), from "eclipsevert-dot-x" to "eclipsevertdotx"
- Ember.js (#5611), from "ember-dot-js" to "emberdotjs"
- F-Droid (#5611), from "f-droid" to "fdroid"
- F-Secure (#5611), from "f-secure" to "fsecure"
- Ferrari N.V. (#5611), rom "ferrarin-dot-v-dot" to "ferrarinv"
- Fraunhofer-Gesellschaft (#5611), from "fraunhofer-gesellschaft" to "fraunhofergesellschaft"
- freedesktop.org (#5611), from "freedesktop-dot-org" to "freedesktopdotorg"
- GOG.com (#5611), from "gog-dot-com" to "gogdotcom"
- Hotels.com (#5611), from "hotels-dot-com" to "hotelsdotcom"
- Itch.io (#5611), from "itch-dot-io" to "itchdotio"
- Ko-fi (#5611), from "ko-fi" to "kofi"
- Last.fm (#5611), from "last-dot-fm" to "lastdotfm"
- Libraries.io (#5611), from "libraries-dot-io" to "librariesdotio"
- Mail.Ru (#5611), from "mail-dot-ru" to "maildotru"
- Material-UI (#5611), from "material-ui" to "materialui"
- Max-Planck-Gesellschaft (#5611), from "max-planck-gesellshaft" to "maxplanckgesellshaft"
- Micro.blog (#5611), from "micro-dot-blog" to "microdotblog"
- MobX-State-Tree (#5611), from "mobx-state-tree" to "mobxstatetree"
- New Japan Pro-Wrestling (#5611), from "newjapanpro-wrestling" to "newjapanprowrestling"
- Next.js (#5611), from "next-dot-js" to "nextdotjs"
- Node-RED (#5611), from "node-red" to "nodered"
- Node.js (#5611), from "node-dot-js" to "nodedotjs"
- Nuxt.js (#5611), from "nuxt-dot-js" to "nuxtdotjs"
- p5.js (#5611), from "p5-dot-js" to "p5dotjs"
- Parse.ly (#5611), from "parse-dot-ly" to "parsedotly"
- Pi-hole (#5611), form "pi-hole" to "pihole"
- Picarto.TV (#5611), from "picatro-dot-tv" to "picartodottv"
- Player.me (#5611), from "player-dot-me" to "playerdotme"
- Pop!_OS (#5073), from "pop_os" to "popos"
- pr.co (#5611), from "pr-dot-co" to "prdotco"
- pre-commit (#5611), from "pre-commit" to "precommit"
- Proto.io (#5611), from "proto-dot-io" to "protodotio"
- protocols.io (#5611), from "protocols-dot-io" to "protocolsdotio"
- Redux-Saga (#5611), from "redux-saga" to "reduxsaga"
- reveal.js (#5611), from "reveal-dot-js" to "revealdotjs"
- Rocket.Chat (#5611), from "rocket-dot-chat" to "rocketdotchat"
- Rolls-Royce (#5611), from "rolls-royce" to "rollsroyce"
- rollup.js (#5611), from "rollup-dot-js" to "rollupdotjs"
- Sat.1 (#5611), from "sat-dot-1" to "sat1"
- scikit-learn (#5611), from "scikit-learn" to "scikitlearn"
- semantic-release (#5611), from "semantic-release" to "semanticrelease"
- Shields.io (#5611), from "shields-dot-io" to "shieldsdotio"
- Socket.io (#5611), from "socket-dot-io" to "socketdotio"
- styled-components (#5611), from "styled-components" to "styledcomponents"
- T-Mobile (#5611), from "t-mobile" to "tmobile"
- Three.js (#5611), from "three-dot-js" to "threedotjs"
- TP-Link (#5611), from "tp-link" to "tplink"
- Trip.com (#5611), from "trip-dot-com" to "tripdotcom"
- ts-node (#5611), from "ts-node" to "tsnode"
- Vue.js (#5611), from "vue-dot-js" to "vuedotjs"
- Warner Bros. (#5611), from "warnerbros-dot" to "warnerbros"
- webcomponents.org (#5611), from "webcomponents-dot-org" to "webcomponentsdotorg"
- Weights & Biases (#5611), from "weights-and-biases" to "weightsandbiases"
- write.as (#5611), from "write-dot-as" to "writedotas"
- X.Org (#5611), from "x-dot-org" to "xdotorg"
- YourTravel.TV (#5611), from "yourtravel-dot-tv" to "yourtraveldottv"
- Z-Wave (#5611), from "z-wave" to "zwave"

# Removed Icons

- Adobe PhoneGap (#5245)
- Automatic (#3982)
- Autotask (#5250)
- Aventrix (#5249)
- Bancontact (#5264)
- Bing (#4744), now "Microsoft Bing"
- Brand.ai (#4365)
- CEVO (#4509)
- ComproPago (#5270)
- Everplaces (#5366)
- EVRY (#4040), now "TietoEVRY"
- FedRAMP (#4046)
- Gauges (#5748)
- GOV.UK (#4060)
- Graphcool (#5602)
- HackHands (#5693)
- Highly (#4243)
- HipChat (#5556)
- HockeyApp (#5038)
- iDEAL (#4577)
- Klout (#5280)
- LINE WEBTOON (#5381), now "WEBTOON"
- Livestream (#4647)
- Mathworks (#5351)
- Monogram (#5345)
- Periscope  (#5415)
- Pingup (#5416)
- Quantopian (#5414)
- repl.it (#5730), now "Replit"
- Sprint (#4710)
- Staticman (#4200)
- Storify (#4204)
- Tencent Weibo (#4222)
- Vine (#5259)
- Virb (#5257)
- X-Pack  (#4239)
- Yandex (#5428)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Issues or pull requests that include a breaking change and scheduled for the next major release update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants