Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sapper alias to Svelte #4866

Merged
merged 5 commits into from
May 7, 2021
Merged

Add Sapper alias to Svelte #4866

merged 5 commits into from
May 7, 2021

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Jan 26, 2021 •
edited

Sapper

Issue: Closes #3219
Alexa rank: n/a
GitHub stars: ~7.1k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Colour from SVG in source header.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Jan 26, 2021
@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jan 26, 2021
adamrusted
adamrusted approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @PeterShaggyNoble! As it's confirming #3270 I'll wait for another approval on this before merging.

@PeterShaggyNoble PeterShaggyNoble marked this pull request as draft January 29, 2021 20:07
@PeterShaggyNoble PeterShaggyNoble added the pending Issues that are pending because of e.g. a scheduled brand update label Jan 29, 2021
@PeterShaggyNoble

This comment has been minimized.

Sign in to view
@PeterShaggyNoble PeterShaggyNoble changed the title Update Svelte and Add Sapper Add Sapper Feb 2, 2021
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Feb 2, 2021
Merged
3 tasks
@PeterShaggyNoble PeterShaggyNoble removed the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Feb 2, 2021
@PeterShaggyNoble PeterShaggyNoble changed the title Add Sapper Add Sapper alias to Svelte May 6, 2021
@PeterShaggyNoble PeterShaggyNoble added icon data and removed new icon Issues or pull requests for adding a new icon pending Issues that are pending because of e.g. a scheduled brand update labels May 6, 2021
@PeterShaggyNoble PeterShaggyNoble marked this pull request as ready for review May 6, 2021 15:51
service-paradis
service-paradis approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@service-paradis service-paradis merged commit ccd1495 into simple-icons:develop May 7, 2021
@PeterShaggyNoble PeterShaggyNoble deleted the add/sapper branch May 7, 2021 15:37
@github-actions github-actions bot mentioned this pull request May 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

@service-paradis service-paradis service-paradis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sapper icon
3 participants
@PeterShaggyNoble @adamrusted @service-paradis