Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom slugs #4918

Merged
merged 13 commits into from
Feb 19, 2021
Merged

Allow custom slugs #4918

merged 13 commits into from
Feb 19, 2021

Commits on Feb 3, 2021

  1. Update JSON scheme, build & test scripts for custom slugs

    @ericcornelissen
    ericcornelissen committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    8e0bc8a View commit details
    Browse the repository at this point in the history

  2. Example: invalid custom slug

    @ericcornelissen
    ericcornelissen committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    6791e47 View commit details
    Browse the repository at this point in the history

  3. Example: valid slug, wrong filename

    @ericcornelissen
    ericcornelissen committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    63dd392 View commit details
    Browse the repository at this point in the history

  4. Example: custom slug, correct filename

    @ericcornelissen
    ericcornelissen committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    a37f73c View commit details
    Browse the repository at this point in the history

  5. Revert to 8e0bc8a

    @ericcornelissen
    ericcornelissen committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    3aa70d9 View commit details
    Browse the repository at this point in the history

  6. Update index.html for custom slugs

    @ericcornelissen
    ericcornelissen committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    b2a2d22 View commit details
    Browse the repository at this point in the history

  7. Example: custom slug for 1Password

    @ericcornelissen
    ericcornelissen committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    dd629af View commit details
    Browse the repository at this point in the history

  8. Revert to b2a2d22

    @ericcornelissen
    ericcornelissen committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    664717f View commit details
    Browse the repository at this point in the history

  9. Make NPM package API backwards compatible with custom slugs

    @ericcornelissen
    ericcornelissen committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    d99028f View commit details
    Browse the repository at this point in the history

  10. Example: two icons with same tile

    @ericcornelissen
    ericcornelissen committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    14a1aa9 View commit details
    Browse the repository at this point in the history

  11. Revert to d99028f 

    And revert unwanted changes in tests.
    @ericcornelissen
    ericcornelissen committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    e16681b View commit details
    Browse the repository at this point in the history

  12. Update NodeJS usage documentation 

    First this updates the documentation to encourage users to get icons by
their slug rather than their title.

Second, I attempted to explain where the name comes from with a comment,
not sure if that works... I do think this could be valuable in general
(i.e. also for CDN usage and indiviual imports in NodeJS) but am unsure
how best to explain it...
    @ericcornelissen
    ericcornelissen committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    0550047 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Merge branch 'develop' into custom-slugs

    @ericcornelissen
    ericcornelissen committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    c77d5f3 View commit details
    Browse the repository at this point in the history