Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Delicious as del.icio.us #5047

Merged
merged 4 commits into from
May 12, 2021
Merged

Rename Delicious as del.icio.us #5047

merged 4 commits into from
May 12, 2021

Conversation

PeterShaggyNoble
Copy link
Member

Issue: Fixes #4791
Alexa rank: ~78.5k (I'm assuming del is the only, or at least primary, subdomain)

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Updates our existing "Delicious" icon to use the stylised "del.icio.us" name. As the new site is in an archived state, we should check the Alexa rank again before merging this.

@PeterShaggyNoble PeterShaggyNoble added update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both breaking change Issues or pull requests that include a breaking change and scheduled for the next major release labels Feb 17, 2021
@PeterShaggyNoble PeterShaggyNoble added this to the v5.0.0 milestone Feb 17, 2021
@PeterShaggyNoble PeterShaggyNoble marked this pull request as draft February 17, 2021 11:28
@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Feb 17, 2021
@PeterShaggyNoble PeterShaggyNoble removed the new icon Issues or pull requests for adding a new icon label Feb 17, 2021
@ericcornelissen
Copy link
Contributor

I guess this goes against what I said in #4936, but I think that when #4918 is merged the (custom) slug should be set to "delicious" (as you don't, presumably, call it "del-dot-icio-dot-us").

or we do go with removing - and _ entirely and instead use custom slugs for e.g. ".Net"

@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Feb 18, 2021
Closed
5 tasks
@PeterShaggyNoble
Copy link
Member Author

PeterShaggyNoble commented May 6, 2021 •
edited

After reviewing a few other slugs for #5611, I am now of the opinion that we should, in rare cases, make allowances when the .s in a brand's name are not pronounced so I've updated this PR accordingly. This is probably no longer a breaking change now as it's just the titles in the JSON & SVG that are being changed, with the addition of a slug to allow the filename to remain unchanged.

ericcornelissen
ericcornelissen approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this would not be breaking 👍

I would be in favour of this approach. As it concerns a custom slug, I will leave it for at least one more @simple-icons/maintainers to approve this.

adamrusted
adamrusted approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PeterShaggyNoble PeterShaggyNoble marked this pull request as ready for review May 7, 2021 21:02
@PeterShaggyNoble
Copy link
Member Author

Added "Delicious" as an alias for people searching for the un-stylised version. I added it as an aka rather than an old as they use it themselves in a few places.

Separately, we may want to once again consider removing this as their website has been down for a few days as their SSL cert expired on the 4th.

@adamrusted
Copy link
Member

Separately, we may want to once again consider removing this as their website has been down for a few days as their SSL cert expired on the 4th.

If you're willing to visit without the SSL, the site's still there - so I think we're okay to keep it for now. Good to keep an eye on though. Were we waiting for v5 on this one, or is it ready for merge now?

@ericcornelissen
Copy link
Contributor

Added "Delicious" as an alias for people searching for the un-stylised version. I added it as an aka rather than an old as they use it themselves in a few places.

Good call 👍

Separately, we may want to once again consider removing this as their website has been down for a few days as their SSL cert
expired on the 4th.

If you're willing to visit without the SSL, the site's still there - so I think we're okay to keep it for now. Good to keep an eye on though. Were we waiting for v5 on this one, or is it ready for merge now?

I agree that an (recently) expired SSL certificate is not a reason for us to remove the icon.

This is good to merge, but I'll leave some time for @PeterShaggyNoble to respond to this discussion on removing it or not.

@ericcornelissen ericcornelissen removed this from the v5.0.0 milestone May 11, 2021
@PeterShaggyNoble
Copy link
Member Author

Yup, agreed. If it's still down come the week of v5, we can discuss it then.

Merging this in, so.

@PeterShaggyNoble PeterShaggyNoble merged commit 3e5a81a into simple-icons:develop May 12, 2021
@PeterShaggyNoble PeterShaggyNoble deleted the rename/delicious branch May 12, 2021 14:42
@github-actions github-actions bot mentioned this pull request May 16, 2021
Merged
ericcornelissen added a commit that referenced this pull request May 16, 2021
@ericcornelissen
Release 17 new icons and 71 updated icons (v4.24.0)
06d3a04 
# New Icons

- Alacritty (#5581)
- AllTrails (#5624)
- BookStack (#5141)
- CKEditor 4 (#5159)
- Data Version Control (#5674)
- Eclipse Jetty (#5461)
- Expensify (#5670)
- Grid.ai (#5423)
- JUnit5 (#5644)
- LOT Polish Airlines (#5221)
- osu! (#5347)
- Processing Foundation (#4963)
- PyTorch Lightning (#5663)
- R3 (#5551)
- RxDB (#5622)
- Simkl (#5039)
- Zerodha (#5669)

# Updated Icons

- Apple Music (#5668)
- Consul (#5650)
- del.icio.us (#5047)
- Discord (#5692)
- FARFETCH (#5539)
- Fedora (#5678)
- Feedly (#5539)
- Ferrari (#5539)
- Fido Alliance (#5539)
- FileZilla (#5539)
- Flask (#5539)
- Flickr (#5539)
- Fluentd (#5539)
- Flutter (#5539)
- G2A (#5601)
- Game Jolt (#5601)
- Garmin (#5601)
- Gatsby (#5601)
- Gentoo (#5601)
- Geocaching (#5601)
- Ghost (#5601)
- Ghostery (#5601)
- GIMP (#5601)
- GIPHY (#5601)
- GitBook (#5601)
- Gitee (#5601)
- Glassdoor (#5601)
- GNU Bash (#5601)
- Go (#5601)
- Godot Engine (#5601)
- Google (#5601)
- Google Ads (#5601)
- Google Cast (#5601)
- Google Chrome (#5601)
- Google Fit (#5601)
- Google Hangouts (#5601)
- Google Lens (#5601)
- Google News (#5601)
- Google Pay (#5601)
- Google Photos (#5601)
- Google Play (#5601)
- Google Street View (#5601)
- Gradle (#5601)
- GraphQL (#5601)
- Gravatar (#5601)
- Gridsome (#5601)
- Groupon (#5601)
- Grunt (#5601)
- gulp (#5601)
- HackerRank (#5659)
- Indeed (#5691)
- InfluxDB (#5697)
- Inkscape (#5686)
- Internet Archive (#5698)
- Qgis (#5388)
- Qi (#5388)
- Qiita (#5388)
- Qt (#5388)
- Qualtrics (#5388)
- Quantcast (#5388)
- Quasar (#5388)
- Quest (#5388)
- QuickBooks (#5388)
- Super User (#5694)
- Terraform (#5650)
- Ubiquiti (#5408)
- Ubuntu (#5408)
- Unreal Engine (#5408)
- Untangle (#5408)
- Vagrant (#5650)
- Vault (#5650)
@PeterShaggyNoble PeterShaggyNoble removed the breaking change Issues or pull requests that include a breaking change and scheduled for the next major release label May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

@ericcornelissen ericcornelissen ericcornelissen approved these changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename or Remove Delicious
3 participants
@PeterShaggyNoble @ericcornelissen @adamrusted