Add Slugs to Contributing Guidelines #5150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterShaggyNoble
added
the
meta
ericcornelissen
approved these changes
Mar 2, 2021
mondeja
reviewed
Mar 4, 2021
mondeja
reviewed
Mar 4, 2021
Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
mondeja
approved these changes
Mar 4, 2021
PeterShaggyNoble
added a commit
to PeterShaggyNoble/simple-icons
that referenced
this pull request
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Follow-up to #4946, #4918 & #5002
Alexa rank: n/a
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
This PR adds a line to the optional JSON data section about how to add a custom slug to an icon's entry and a new bullet point to the filename convention section on how to resolve naming conflicts.
I also moved the section on file names up above the section on the JSON in an effort to improve the workflow. As it was, we would have been explaining how to add a slug before explaining what a slug is or how to construct it. This way the contributor will know what a slug is and what their specific icon's slug is before they get to the explanation on how to add it to the JSON.