Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter I review #5496

Merged
merged 29 commits into from Apr 23, 2021
Merged

Conversation

service-paradis
Copy link
Member

@service-paradis service-paradis commented Apr 21, 2021

Issue: #5251

Notes

- Update source
- Add guidelines
- Update source
- Add guidelines
- Update source
- Add guidelines
- Add guidelines
- Update hex
- Update source
- Add guidelines
- Update source
- Add guidelines
- Update source
- Add guidelines
- Update source
- Add guidelines
- Update source
- Update source
- Update source
- Add license
- Update source
- Add guidelines
- Update source
- Add guidelines
- Update source
- Update source
- Add guidelines
- Add guidelines
- Update source
@PeterShaggyNoble
Copy link
Member

I think we need to update https://www.informatica.com/ to add gaps

I don't know that we'd need gaps between the various shades of orange but I do think we should do something to provide some separation between the purple shape and the rest

I think we need to update https://inkscape.org/gallery/=inkscape-branding/inkscape-brand-assets/. The monochrome version available is different

Agreed.

To review the first few changes in this PR:

  • I think we should go with https://www.ibm.com/design/language/ibm-logos/8-bar/ for the IBM guidelines as it includes details on the usage of the specific logo we've used?
  • Looks like we need to update the IBM colour too; I don't see any mentioned of the blue we currently use on this page. Which blue we should use, though, I'm not sure as they don't seem to state a clear preference and they themselves use a number of blues not present in their palette. Keeping it consistent with the shade birjolaxew picked in Add IBM #1768, though, we could go with the current "Blue 70" of #0043ce.
  • Do we need to update the IBM SVG to include the trademark symbol to be safe.
  • Agree with that change to the ICON source 👍🏻
  • We'll need to update our ICON icon, though, as their are differences between it (in red) and the vector files available for download.
  • Agree with the addition of the iDEAL guidelines, even if it is scheduled for removal 👍🏻
  • As the new page doesn't include any vector artwork, I'd leave the iFixit source as is and add the new page for the guidelines instead as it includes a line about requesting permission before using their logo.
  • Agree with the addition of the guidelines entry for IFTTT & iHeartRadio 👍🏻
  • Agree with the changes to IMDb 👍🏻
  • Should we update our IMDb icon to use the outline version instead? If not then we should at least double check that our current version is consistent with what's available to download at the new source
  • Agree with the changes to Imgur, even though the icon isn't directly available at the new source 👍🏻

I'll be back to review the rest later, if someone else doesn't beat me to it.

This was referenced Apr 22, 2021
@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Apr 22, 2021

Continuing on ...

  • Looks like we need to update the Indeed hex to #003a9b
  • Agree with change to the Indeed source 👍🏻
  • I don't think we need to add the guidelines entry for Indeed as it doesn't provide any information on how the icon should be used
  • Looks like we'll need to update our Indeed icon, some major differences between it (in red) and the new source files
  • Should we update the InfluxData hex to the "Deep Purple" seen here? It looks to be pretty widely used on their website.
  • Agree with the change to the InfluxData 👍🏻
  • Some minor differences between our InfluxData icon (in red) and those available at the new source so we'll need to update that
  • Agree with the changes to Informatica & Infosys 👍
  • We need to update our Infosys icon to fix the differences between it and the new source AI file (example)
  • Agree with the changes to Inkscape, Instagram, Intel, Intercom & Internet Archive 👍🏻 (Although Intel don't (yet) have vector files available to download, the logo in the header is still an SVG)
  • Our Internet Archive icon needs to be updated based on the new source - differences, with ours in red
  • The hex for Internet Archive probably needs to be update to one of the greys

I'll get the last few done later on today.

This was referenced Apr 22, 2021
This was referenced Apr 22, 2021
- Update guidelines
- Add guidelines
- Update hex
- Remove guidelines
@service-paradis
Copy link
Member Author

Thank you @PeterShaggyNoble for the review, really appreciated!

I think we should go with https://www.ibm.com/design/language/ibm-logos/8-bar/ for the IBM guidelines as it includes details on the usage of the specific logo we've used?

You're right, done!

Looks like we need to update the IBM colour too; I don't see any mentioned of the blue we currently use on this page. Which blue we should use, though, I'm not sure as they don't seem to state a clear preference and they themselves use a number of blues not present in their palette. Keeping it consistent with the shade birjolaxew picked in #1768, though, we could go with the current "Blue 70" of #0043ce.

You're right. I had it noted, but forgot to add it as a note in my PR. Thanks for catching it! Blue 70 is probably a good choice. According to the IBM developper guidelines, Blue 60 might be a good choice too.

Blue 60 is also the second color used in their main carousel - #0530ad and #0f62fe (Blue 60):
Capture d’écran 2021-04-22 084807

Do we need to update the IBM SVG to include the trademark symbol to be safe.

This section mention the trademark symbol, but I thought it is for "printed literature" only... Not too sure...

As the new page doesn't include any vector artwork, I'd leave the iFixit source as is and add the new page for the guidelines instead as it includes a line about requesting permission before using their logo.

👍

  • Looks like we need to update the Indeed hex to #003a9b
  • I don't think we need to add the guidelines entry for Indeed as it doesn't provide any information on how the icon should be used

Indeed, done!

Should we update the InfluxData hex to the "Deep Purple" seen here? It looks to be pretty widely used on their website.

It is, for sure, the primary color of InfluxData. InfluxDB tend to use blue through their interface.
image

The hex for Internet Archive probably needs to be update to one of the greys

Agreed, I updated it to use #666666 used as search backgrond in header and for cards background. What do you think?

@PeterShaggyNoble
Copy link
Member

Do we need to update the IBM SVG to include the trademark symbol to be safe.

This section mention the trademark symbol, but I thought it is for "printed literature" only... Not too sure...

They mention videos as well so it would seem to apply to physical and digital media. And while it mentions it only being required in the US, I think the language for the ret of the world is ambiguous enough for us to invoke our own consensus on its inclusion.

Anyway, on to the last few - didn't realise there were so few left or I would have kept going! - and then I'll take another pass over it:

  • Our Invoice Ninja icon was actually manually vectorised from this file by phatbhoy67 in Add Invoice Ninja icon (#1612) #1948 so we should probably use that for the source URL. The SVG source is poorly Potraced (although I've seen worse) from that PNG.
  • Agree with the change to ioBroker; that's the very file I based our version off 👍🏻
  • Agree with the changes to Issuu & Itch.io 👍🏻
  • I think we should leave the IVECO source as-is as the new one doesn't include a vector logo. Although the file @runxel based our version off is no longer present so we should double check that ours still lines up with this new SVG found at the same source.

@service-paradis
Copy link
Member Author

  • Our Invoice Ninja icon was actually manually vectorised from this file by phatbhoy67 in Add Invoice Ninja icon (#1612) #1948 so we should probably use that for the source URL. The SVG source is poorly Potraced (although I've seen worse) from that PNG.

Alright, done!

  • I think we should leave the IVECO source as-is as the new one doesn't include a vector logo. Although the file @runxel based our version off is no longer present so we should double check that ours still lines up with this new SVG found at the same source.

Weird, was not able to access this page 2 days ago 🤔 Reverted!

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, @service-paradis, nice work 👍🏻

If anyone wants to propose alternative colours for IBM or Internet Archive or feel we should update the colour for InfluxDB, we can address those separately.

@PeterShaggyNoble PeterShaggyNoble merged commit 5fd64fd into simple-icons:develop Apr 23, 2021
@service-paradis service-paradis deleted the i-review branch April 23, 2021 11:56
ericcornelissen added a commit that referenced this pull request Apr 25, 2021
# New Icons

- Automattic (#5489)
- Datto (#5493)
- FamPay (#5505)
- Forestry (#5454)
- Immer (#5437)
- KashFlow (#5465)
- Kdenlive (#5193)
- LIFX (#5448)
- Photopea (#5518)
- pnpm (#5482)

# Updated Icons

- Gitpod (#5464)
- IBM (#5496)
- IBM Watson (#5496)
- ICON (#5496)
- Iconfinder (#5496)
- iDEAL (#5496)
- IEEE (#5496)
- iFixit (#5496)
- iFood (#5496)
- IFTTT (#5496)
- iHeartRadio (#5496)
- IKEA (#5496)
- IMDb (#5496)
- Imgur (#5496)
- Imou (#5496)
- Indeed (#5496)
- Infiniti (#5496)
- InfluxDB (#5496)
- Informatica (#5496)
- Infosys (#5496)
- Ingress (#5496)
- Inkscape (#5496)
- Insomnia (#5496)
- Instagram (#5496)
- Instapaper (#5496)
- Intel (#5496)
- IntelliJ IDEA (#5496)
- Intercom (#5496)
- Internet Archive (#5496)
- Internet Explorer (#5496)
- Invoice Ninja (#5496)
- ioBroker (#5496)
- Ionic (#5496)
- Issuu (#5496)
- Itch.io (#5496)
- PayPal (#5467)
- Plus Codes (#5468)
- R (#5285)
- Zotero (#5491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants