Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data for Canonical logo #6323

Merged
merged 4 commits into from Aug 19, 2021

Conversation

gizmecano
Copy link
Contributor

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Any license URL cannot be explicitly added because the license type is only mentioned in a LICENSE.txt file which is embedded in the downloadable archive (entitled canonical-symbol-set-web.zip).

Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gizmecano for your contribution! 💯

Good job by adding the license and guidelines! I only add a single minor comment about the source URL. It will be ready to merge after this 🎉

_data/simple-icons.json Outdated Show resolved Hide resolved
Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gizmecano 💯

@service-paradis service-paradis merged commit 0a3621d into simple-icons:develop Aug 19, 2021
ericcornelissen added a commit that referenced this pull request Aug 22, 2021
# New Icons

- Alfred (#6274)

# Updated Icons

- Canonical (#6323)
- Guangzhou Metro (#6218)
- Signal (#6216)
- TrainerRoad (#6122)
- Unreal Engine (#6282)
@gizmecano gizmecano deleted the input/data/canonical branch August 22, 2021 09:00
jorgeamadosoria pushed a commit that referenced this pull request Aug 24, 2021
* Update data for Canonical logo

* Update source link

(according to #6323 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants