Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal for clarification about links to be included for icon source data #6364

Merged
merged 8 commits into from
Aug 30, 2021
Merged

Proposal for clarification about links to be included for icon source data #6364

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
748e4fc
Clarification about links to be included for icon source data
gizmecano Aug 24, 2021
37f0385
Revise inserted paragraph
gizmecano Aug 26, 2021
fb4d463
Merge branch 'develop' into input/root/source-guidelines
gizmecano Aug 26, 2021
2914d73
Merge branch 'develop' into input/root/source-guidelines
gizmecano Aug 27, 2021
2a3d3e2
Revise preceding sections
gizmecano Aug 28, 2021
b3dec7d
Merge branch 'develop' into input/root/source-guidelines
gizmecano Aug 28, 2021
2a56af5
Update only existing sentences
gizmecano Aug 28, 2021
9d248ba
Merge branch 'develop' into input/root/source-guidelines
gizmecano Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,9 @@ If the SVG is sourced from:

- **Branding page**: For an SVG from a branding page the source URL should simply link to the branding page.
- **Company website**: If the SVG is found on the company website (but there is no branding page) the source URL should link to a common page, such as the home page or about page, that includes the source material.

In both cases above (**Branding page** and **Company website**), pay attention to link to a **page** that includes file instead of link to direct files. This way, if the file name or path changes, the link will still be working.

- **GitHub**: For an SVG from a GitHub (GitLab, BitBucket, etc.) repository the source URL should link to the file that was used as source material. If the color comes from another file in the repository the URL should link to the repository itself.

In any case the commit hash should be part of the URL. On GitHub, you can get the correct URL by pressing <kbd>y</kbd> on the GitHub page you want to link to. You can get help at the [getting permanent links to files page](https://help.github.com/en/github/managing-files-in-a-repository/getting-permanent-links-to-files).
Expand Down