Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding penpot icon griger #6703

Conversation

grivasgervilla
Copy link

Issue: #6664
Alexa rank: 297,05. See https://www.alexa.com/siteinfo/penpot.app

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I have take the branding colour, #000000, from the logo itself. In the JSON file I have add the URL to the SVG logo in the Penpot's repository.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Oct 10, 2021
@sachinraja
Copy link
Contributor

I believe checks are failing on this because the icon has not been optimized. Please read this section of the contributing guidelines.

@grivasgervilla
Copy link
Author

I believe checks are failing on this because the icon has not been optimized. Please read this section of the contributing guidelines.

Hi, @sachinraja. I think that I have optimized this icon using the SVGOMG tool. Did I do it wrong?

@sachinraja
Copy link
Contributor

@griger You may have not copied it from SVGOMG correctly. After running it through SVGOMG I get this:

<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><path d="M7.665.031 5.148 3.577V5.58l-2.19 1.042-.02-.01v13.075l8.54 4.034.522.247.522-.247 8.54-4.034V6.613l-.016.008-2.191-1.042V3.577l-.077-.108L16.338.03 13.82 3.577v.003L11.99 1 10.17 3.56l-.065-.091zm.446 2.06.973 1.37H6.247l.962-1.354Zm8.672 0 .973 1.37h-2.838l.963-1.354zm-4.35.969.974 1.371H10.57l.962-1.355ZM5.978 4.153h1.346v4.532l-1.345-.636Zm2.037 0h1.34v5.49l-1.34-.632Zm6.635 0h1.346v4.854l-1.346.635v-5.49zm2.037 0h1.34v3.894l-1.34.633zm-6.385.969h1.345v5.605l-1.345-.636zm2.036 0h1.34v4.98l-1.34.633zm6.517 1.49 1.185.484-1.185.56zm-13.706.001v1.044l-1.184-.56ZM3.982 8.261l7.496 3.54v10.767l-7.496-3.541Zm16.036 0v10.766l-7.496 3.54V11.803Z"/></svg>

@grivasgervilla
Copy link
Author

@sachinraja, sorry for bothering you. But, I have added the title tag because in the contributing guidelines it is said that the SVG file should be annotated. Am I wrong?

@sachinraja
Copy link
Contributor

sachinraja commented Oct 10, 2021

No worries, I'm happy to help, feel free to ask any questions you have. The title tag is correct. The problem is the precision of the icon. You may want to reset to defaults on SVGOMG or just try again. Also, note the order of the steps in the contributing guidelines. You should optimize the icon first and then annotate it because the configuration on SVGOMG will remove the annotations (which is why the SVG I sent does not have the title element).

@service-paradis service-paradis linked an issue Oct 13, 2021 that may be closed by this pull request
@adamrusted
Copy link
Member

Closing as Penpot was merged in #7911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Penpot
3 participants