Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wayland icon #7967

Merged
merged 1 commit into from Jan 12, 2023
Merged

Add Wayland icon #7967

merged 1 commit into from Jan 12, 2023

Conversation

valpackett
Copy link
Contributor

wayland

Issue: closes #5056

Similarweb rank: 馃し

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

See #5056

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Oct 17, 2022
@LitoMore LitoMore changed the title Add Wayland icon, fixes #5056 Add Wayland icon Oct 17, 2022
Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @unrelentingtech! 馃檹

I wonder whether there is a way to retain the shapes outside the circle. Currently, everything outside the circle is removed. Since I can't find an official monochromatic icon for Wayland, we might need to come up with something ourselves.

I imagine we could add inset strokes for the missing part of the "W" above the circle. And perhaps the sprinkles above the circle could be filled shapes. WDYT, @unrelentingtech and also @simple-icons/icon-review?

@valpackett
Copy link
Contributor Author

Sprinkles would look okay filled (inverted) but I think the parts of the W would look awkward no matter what, so I went with just the stuff inside the circle.

@sisp
Copy link
Contributor

sisp commented Oct 25, 2022

Okay, I agree. Would you mind updating the icon to include the inverted sprinkles?

@valpackett
Copy link
Contributor Author

test:

waylandtest

I don't think this is better. The extra sprinkles are silly, they don't add much but make the circle necessarily smaller.

Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. That actually doesn't look good.

I'll accept your proposed icon, just found some differences between the original one and yours:

Would you mind checking your conversion steps?

@valpackett
Copy link
Contributor Author

I used Inkscape to subtract the W path from the circle path and resize the result to fit the 24x24 viewbox, and used SVGO to trim the path precision down to 3 decimals. I think. I might have actually involved rsvg-convert to resize the viewbox specifically which would've been a bit silly in retrospect. These don't seem like major differences 馃し but I can redo everything I guess

@LitoMore
Copy link
Member

LitoMore commented Nov 1, 2022

@valpackett Could you try with precision 4? You could refer to this #7908 (comment).

@valpackett
Copy link
Contributor Author

Updated with higher precision

Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated icon. Unfortunately, there are still notable differences when I compare it with the original one:

When I derive the icon, my steps are:

  1. Ungroup all paths.
  2. Subtract the "W" (+ sprinkles) path from the circle path.
  3. Change the height to 24 while retaining the aspect ratio. The aspect ratio of the original icon is not exactly 1:1, its height is slightly larger than its width.
  4. Change the viewport to 24x24 and center the path.

I perform all conversion steps with the highest possible precision in Boxy SVG.

When I compare this icon with optimized versions using SVGOMG, I get the following difference with a precision of 3

and with a precision of 4:

There are some tiny negligible differences with a precision of 3 and practically no differences with a precision of 4.

I've suggested the path data of my derivation with a precision of 3 in case you're interested.

icons/wayland.svg Outdated Show resolved Hide resolved
@sisp
Copy link
Contributor

sisp commented Jan 9, 2023

/ping @valpackett

@valpackett
Copy link
Contributor Author

oh, sorry. Okay, merged your suggestion, now the linter complains that it's 23.964 x 23.999 and no dimension is exactly 24. oops..

Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valpackett Apologies for my negligence. I've made tiny change in the path data and svglint now passes locally for me.

icons/wayland.svg Outdated Show resolved Hide resolved
Co-authored-by: Sigurd Spieckermann <https://github.com/sisp>
@valpackett
Copy link
Contributor Author

Thanks, merged everything now

Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 馃帀 Thanks, @valpackett! 馃檹

@sisp sisp merged commit 5cfce37 into simple-icons:develop Jan 12, 2023
@valpackett valpackett deleted the wayland branch January 12, 2023 19:25
mondeja added a commit that referenced this pull request Jan 18, 2023
# New Icons

- Alchemy (#8122)
- Answer (#8161)
- BoardGameGeek (#8191)
- Chainguard (#8057)
- Creative Technology (#8227)
- Envoy Proxy (#8143)
- Fluxus (#8111)
- Monica (#8110)
- TGA (#8117)
- TNT (#8204)
- Wayland (#7967)

# Updated Icons

- NativeScript (#8174)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wayland (display server protocol)
3 participants