New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wayland icon #7967
Add Wayland icon #7967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @unrelentingtech! 馃檹
I wonder whether there is a way to retain the shapes outside the circle. Currently, everything outside the circle is removed. Since I can't find an official monochromatic icon for Wayland, we might need to come up with something ourselves.
I imagine we could add inset strokes for the missing part of the "W" above the circle. And perhaps the sprinkles above the circle could be filled shapes. WDYT, @unrelentingtech and also @simple-icons/icon-review?
Sprinkles would look okay filled (inverted) but I think the parts of the W would look awkward no matter what, so I went with just the stuff inside the circle. |
Okay, I agree. Would you mind updating the icon to include the inverted sprinkles? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used Inkscape to subtract the |
@valpackett Could you try with precision 4? You could refer to this #7908 (comment). |
Updated with higher precision |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updated icon. Unfortunately, there are still notable differences when I compare it with the original one:
When I derive the icon, my steps are:
- Ungroup all paths.
- Subtract the "W" (+ sprinkles) path from the circle path.
- Change the height to 24 while retaining the aspect ratio. The aspect ratio of the original icon is not exactly 1:1, its height is slightly larger than its width.
- Change the viewport to 24x24 and center the path.
I perform all conversion steps with the highest possible precision in Boxy SVG.
When I compare this icon with optimized versions using SVGOMG, I get the following difference with a precision of 3
and with a precision of 4:
There are some tiny negligible differences with a precision of 3 and practically no differences with a precision of 4.
I've suggested the path data of my derivation with a precision of 3 in case you're interested.
/ping @valpackett |
oh, sorry. Okay, merged your suggestion, now the linter complains that it's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valpackett Apologies for my negligence. I've made tiny change in the path data and svglint
now passes locally for me.
Co-authored-by: Sigurd Spieckermann <https://github.com/sisp>
Thanks, merged everything now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 馃帀 Thanks, @valpackett! 馃檹
Issue: closes #5056
Similarweb rank: 馃し
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
See #5056