Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Flask icon #8688

Closed

Conversation

robertgodfrey
Copy link

@robertgodfrey robertgodfrey commented May 28, 2023

Icon Preview

Issue: No open issue for this update

Popularity: 63k stars on GitHub

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Flask recently changed their logo. The new logo can be seen on the official Flask website and in the GitHub repo.

I manually vectorized the new logo in Adobe Illustrator. The hex value was chosen based on the color of the shortcut icon in the GitHub repo (previous link).

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label May 28, 2023
@LitoMore
Copy link
Member

It would be better to get vector source files in SVG or other formats from their official team.

@robertgodfrey
Copy link
Author

Agreed, will look a little harder for the official version.

@adamrusted
Copy link
Member

@robertgodfrey - any joy finding an SVG version of the icon? Any contacts on the Flask team we could ask?

@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jul 7, 2023
@robertgodfrey
Copy link
Author

No luck, I tried asking a few times on their Discord but never received a response. Not sure where else to look/ask

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some slight differences between this and the source SVG, but I'm fine with that given it's a manual vectorization. Before we accept, I'll ask another @simple-icons/icon-review member to have a look over it, just to be sure we're in agreement!

Thanks for your work on this @robertgodfrey!

@adamrusted adamrusted removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jul 8, 2023
@adamrusted adamrusted requested a review from LitoMore July 8, 2023 13:55
@LitoMore
Copy link
Member

LitoMore commented Jul 8, 2023

My previous solution is to submit the vectorized image to the source project to replace their existing binary image. See #7702 (comment).

For Flask, since its source image is used for favicon, we should care about compatibility. See https://caniuse.com/link-icon-svg.

In short, we can always provide our vectorized image as a proposal in future similar cases.

In this case, the vectorized Flask icon looks good to me.

@adamrusted
Copy link
Member

@robertgodfrey - would you want to propose the SVG you've created to their repo, so another alternative for them? That way, if that gets merged in - we've got an official source. Feel free to use @LitoMore's message to .ENV as an example! I won't merged this until we hear one way or the other from Flask team - as that may change our source file.

@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jul 8, 2023
@LitoMore LitoMore mentioned this pull request Jul 12, 2023
3 tasks
@adamrusted adamrusted added the vector unavailable Issues and Pull Requests where no official SVG is available. label Jul 18, 2023
@adamrusted
Copy link
Member

Any update on this @robertgodfrey?

@robertgodfrey
Copy link
Author

No, sorry. We can just close this and wait for the Flask team to provide an official image.

@adamrusted adamrusted closed this Aug 25, 2023
@adamrusted adamrusted added abandoned Pull requests that have been abandoned by the contributor and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both vector unavailable Issues and Pull Requests where no official SVG is available. labels Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned Pull requests that have been abandoned by the contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants