Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: PSR-3 compatible Logger #1438

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

WIP: PSR-3 compatible Logger #1438

wants to merge 7 commits into from

Conversation

tvdijen
Copy link
Member

@tvdijen tvdijen commented Mar 11, 2021

This checks some of the boxes in #371:

  • Extract the log levels definition from \SimpleSAML\Logger and use the ones defined by Psr\Log\LogLevel instead.
  • Add a $context parameter to all the methods defined by Psr\Log\LoggerInterface.
  • Make the \SimpleSAML\Logger class extend Psr\Log\AbstractLogger.
  • Make the \SimpleSAML\Logger::log() method public and make it throw a \Psr\Log\InvalidArgumentException if the log level is unknown.

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #1438 (bfaeb14) into master (7a1d8e6) will decrease coverage by 6.96%.
The diff coverage is 33.33%.

❗ Current head bfaeb14 differs from pull request most recent head aa21c42. Consider uploading reports for the commit aa21c42 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1438      +/-   ##
============================================
- Coverage     45.48%   38.53%   -6.96%     
+ Complexity     3692     3482     -210     
============================================
  Files           158      139      -19     
  Lines         12292    10373    -1919     
============================================
- Hits           5591     3997    -1594     
+ Misses         6701     6376     -325     

@tvdijen tvdijen force-pushed the master branch 4 times, most recently from 29f7b69 to 1a911ce Compare May 12, 2023 16:07
@tvdijen tvdijen force-pushed the master branch 3 times, most recently from c7c8357 to fdbe001 Compare June 12, 2023 14:28
@tvdijen tvdijen force-pushed the master branch 8 times, most recently from 3b5f5ba to 96357ee Compare July 19, 2023 12:37
@tvdijen tvdijen force-pushed the master branch 5 times, most recently from 7587851 to d523b31 Compare August 2, 2023 11:58
@tvdijen tvdijen force-pushed the master branch 3 times, most recently from 8c90121 to d534e3b Compare September 5, 2023 08:09
@tvdijen tvdijen force-pushed the master branch 2 times, most recently from bc1c5c8 to d0a5974 Compare October 17, 2023 21:17
@tvdijen tvdijen force-pushed the master branch 3 times, most recently from ccb9b02 to 120a100 Compare December 1, 2023 14:34
@tvdijen tvdijen force-pushed the master branch 2 times, most recently from 6004a77 to 58bf8db Compare May 4, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant