feat: store authsources in a database (fix #267) #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If parameters: - 'authsources.storage' => 'database', - 'authsources.database_table' => 'authsources', are present into config/config.php authsources are retrieved from database, else them are retrieved from file
If parameters: - 'authsources.storage' => 'database', - 'authsources.database_table' => 'authsources', are present into config/config.php authsources are retrieved from database, else them are retrieved from file
|
I don't think we should put a lot of code in a configuration file... |
Moved code out from authsources config file |
tvdijen
reviewed
Jun 22, 2023
tvdijen
reviewed
Jun 22, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1817 +/- ##
============================================
- Coverage 45.24% 45.20% -0.05%
- Complexity 3632 3634 +2
============================================
Files 162 162
Lines 12303 12323 +20
============================================
+ Hits 5566 5570 +4
- Misses 6737 6753 +16 |
tvdijen
force-pushed
the
master
branch
8 times, most recently
from
3b5f5ba
to
96357ee
Compare
tvdijen
force-pushed
the
master
branch
5 times, most recently
from
7587851
to
d523b31
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
a7b59f3
to
6f84bae
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
bc1c5c8
to
d0a5974
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
ccb9b02
to
120a100
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
6004a77
to
58bf8db
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
5c9fb2c
to
0970efc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If, into config/config.php, are present the parameters:
then authsources are retrieved from database,
else them are retrieved from file same authsources.php, as before.
If the value of parameter
authsources.storageis 'database', then the authsource configuration is retrieved from database.If the table referred by the parameter
authsources.database_tabledoes not exists it will be created.The table will contain the following fields:
idVARCHAR(255) PRIMARY KEY, that is the key of authsourceentity_dataJSON, that is the configuration of authsource_disabledenum('N','Y') NOT NULL DEFAULT 'N', to enable/disable the authsource