Migrate metadata generation to new SAML2-library #1901
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1901 +/- ##
============================================
- Coverage 44.59% 44.10% -0.49%
+ Complexity 3743 3720 -23
============================================
Files 166 165 -1
Lines 12728 12728
============================================
- Hits 5676 5614 -62
- Misses 7052 7114 +62 |
tvdijen
force-pushed
the
saml2v5_metadata
branch
from
f49e643
to
31fc0f2
Compare
tvdijen
force-pushed
the
saml2v5_metadata
branch
from
31fc0f2
to
98228fb
Compare
tvdijen
force-pushed
the
saml2v5_metadata
branch
4 times, most recently
from
7cd3f83
to
74d478c
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
ccb9b02
to
120a100
Compare
tvdijen
force-pushed
the
saml2v5_metadata
branch
from
74d478c
to
80b1a9d
Compare
tvdijen
force-pushed
the
saml2v5_metadata
branch
5 times, most recently
from
d4f8ce4
to
e0b429d
Compare
tvdijen
force-pushed
the
saml2v5_metadata
branch
from
e0b429d
to
ab9195e
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
6004a77
to
58bf8db
Compare
…ta (#2082) * MetaDataStorageHandler::getGenerated uses a hook to allow ADFS metadata * fix coding style --------- Co-authored-by: Tim van Dijen <tvdijen@gmail.com>
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
5c9fb2c
to
0970efc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to partially migrate to the new SAML2 library. First run: metadata generation!
To do:
MetadataBuilderclass.MetadataParserclass as a replacement of the oldSAMLParserclass. This class should be able to parse XML metadata into SimpleSAMLphp's array-format. TheSignerclass should become obsolete.MetadataBuilderclass. This also requires us to add a few missing classes to the ws-security library and . Missing classes are: