Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure2Name Attribute Mapping for SAML Claims #1997

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Whats-A-MattR
Copy link

Adding mappings for Azure/Entra Enterprise Application SAML Sign-on, including a commonly included option of 'groups'.

Without these transformations, Azure / Entra can be very painful to use as an IdP.

@thijskh
Copy link
Member

thijskh commented Mar 11, 2024

Thanks! Would it make sense to map the attributes to the same target "names" as the other 2name maps use. E.g. email and sn?

I also wonder if the name azure is not better replaced by entra now.

@Whats-A-MattR
Copy link
Author

Definitely agree on the topic of Entra vs Azure as that is the correct nomenclature.

As for mapping to match other 2name maps I can definitely see value in doing that, though I think there is also something to be said for the simplicity of a close-to-vendor mapping as it's an easier mental model. Transformations would then take place on callback etc.

Is it worth having two attributemaps? One for a 1:1 mapping where the schema gets cleaned up and made usable (like the example I provided) and one that fits the 2name standard?

Totally up to maintainers as to what the preferred method is, just my two cents :)

@thijskh
Copy link
Member

thijskh commented Mar 12, 2024

My idea for using the same names is that if you have multiple IdPs from different vendors you can all map their incoming attributes to the same names. And also you can use the name2 maps then to map them out to other formats again. So it becomes more interchangable and connectible rather than just a translation from one string to a shorter string.

added 2name to map back to SAML
@Whats-A-MattR
Copy link
Author

Whats-A-MattR commented Mar 12, 2024

I've updated the map file name to Entra, and the mappings to match other 2name mappings.
Additionally, I've added a name2 mapping for casting back to SAML.

Let me know your thoughts.

@Whats-A-MattR
Copy link
Author

@thijskh just bumping :)

@tvdijen tvdijen force-pushed the master branch 2 times, most recently from 6004a77 to 58bf8db Compare May 4, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants