translations: copy non empty translation for very core modules #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a translation in messages.po has no msgstr but one is available in the core, saml, or admin modules then copy it to the messages.po file. The opposite is also included as well to avoid empty transation strings if possible.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## simplesamlphp-2.2 #2058 +/- ##
=======================================================
- Coverage 44.82% 44.73% -0.09%
- Complexity 3834 3845 +11
=======================================================
Files 161 161
Lines 12817 12842 +25
=======================================================
Hits 5745 5745
- Misses 7072 7097 +25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a translation in messages.po has no msgstr but one is available in the core, saml, or admin modules then copy it to the messages.po file. The opposite is also included as well to avoid empty transation strings if possible.