-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attributemap claim2name.php to map MS .NET Framework Claim Types to Names #805
base: master
Are you sure you want to change the base?
Conversation
Hi, I don't know why codeclimate fails, log shows nothing depending to this file. Guido |
Thanks @gfaust-qb ! Very useful!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get to your question.. I think you should use the names of the AD attributes..
So you would use c
instead of country
for example
Thank you! I opened an Issue (#807) to discuss this and to offer my help to generate an mapping overview. Guido |
Maps Microsoft .NET Framework ClaimTypes to Names Names in this version are used as described by Microsoft. @see https://msdn.microsoft.com/en-us/library/hh159803.aspx
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
=========================================
Coverage 38.36% 38.36%
Complexity 3385 3385
=========================================
Files 128 128
Lines 9633 9633
=========================================
Hits 3696 3696
Misses 5937 5937 |
1c686ab
to
eb20457
Compare
08ebb9c
to
64fca25
Compare
7a53fc8
to
d73ae47
Compare
e5c0e21
to
d5616df
Compare
2e6ab04
to
32f9acc
Compare
7e3ea19
to
2523634
Compare
29f7b69
to
1a911ce
Compare
c7c8357
to
fdbe001
Compare
3b5f5ba
to
96357ee
Compare
7587851
to
d523b31
Compare
8c90121
to
d534e3b
Compare
bc1c5c8
to
d0a5974
Compare
ccb9b02
to
120a100
Compare
6004a77
to
58bf8db
Compare
5c9fb2c
to
0970efc
Compare
Hi,
second, clean try ;)
I needed a mapping for claim types to names several times and started to create my own attributemap.
I added an attributemap that maps Microsoft .NET Framework (standard) ClaimTypes to Names.
At the moment Names are used as used by Microsoft in their description.
@see https://msdn.microsoft.com/en-us/library/hh159803.aspx
I recognized that these Names do not map to the names in name2claim.php or other attributemaps - but that there are inconsistencies in other mappings also.
Do you have a suggestion what Names I should use to make a valuable contribution to this project?
Guido