Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributemap claim2name.php to map MS .NET Framework Claim Types to Names #805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gfaust-qb
Copy link

@gfaust-qb gfaust-qb commented Mar 2, 2018

Hi,

second, clean try ;)

I needed a mapping for claim types to names several times and started to create my own attributemap.

I added an attributemap that maps Microsoft .NET Framework (standard) ClaimTypes to Names.
At the moment Names are used as used by Microsoft in their description.
@see https://msdn.microsoft.com/en-us/library/hh159803.aspx
I recognized that these Names do not map to the names in name2claim.php or other attributemaps - but that there are inconsistencies in other mappings also.
Do you have a suggestion what Names I should use to make a valuable contribution to this project?

Guido

@gfaust-qb
Copy link
Author

Hi,

I don't know why codeclimate fails, log shows nothing depending to this file.
Does it fail because the file is new?

Guido

@tvdijen
Copy link
Member

tvdijen commented Mar 6, 2018

Thanks @gfaust-qb ! Very useful!!
You can safely ignore the codeclimate-failure.

Copy link
Member

@tvdijen tvdijen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get to your question.. I think you should use the names of the AD attributes..
So you would use c instead of country for example

@gfaust-qb
Copy link
Author

Thank you!

I opened an Issue (#807) to discuss this and to offer my help to generate an mapping overview.

Guido

Maps Microsoft .NET Framework ClaimTypes to Names
Names in this version are used as described by Microsoft.
@see https://msdn.microsoft.com/en-us/library/hh159803.aspx
@codecov
Copy link

codecov bot commented Jun 6, 2020

Codecov Report

Merging #805 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #805   +/-   ##
=========================================
  Coverage     38.36%   38.36%           
  Complexity     3385     3385           
=========================================
  Files           128      128           
  Lines          9633     9633           
=========================================
  Hits           3696     3696           
  Misses         5937     5937           

@tvdijen tvdijen force-pushed the master branch 2 times, most recently from 29f7b69 to 1a911ce Compare May 12, 2023 16:07
@tvdijen tvdijen force-pushed the master branch 3 times, most recently from c7c8357 to fdbe001 Compare June 12, 2023 14:28
@tvdijen tvdijen force-pushed the master branch 8 times, most recently from 3b5f5ba to 96357ee Compare July 19, 2023 12:37
@tvdijen tvdijen force-pushed the master branch 5 times, most recently from 7587851 to d523b31 Compare August 2, 2023 11:58
@tvdijen tvdijen force-pushed the master branch 3 times, most recently from 8c90121 to d534e3b Compare September 5, 2023 08:09
@tvdijen tvdijen force-pushed the master branch 2 times, most recently from bc1c5c8 to d0a5974 Compare October 17, 2023 21:17
@tvdijen tvdijen force-pushed the master branch 3 times, most recently from ccb9b02 to 120a100 Compare December 1, 2023 14:34
@tvdijen tvdijen force-pushed the master branch 2 times, most recently from 6004a77 to 58bf8db Compare May 4, 2024 23:45
@tvdijen tvdijen force-pushed the master branch 2 times, most recently from 5c9fb2c to 0970efc Compare May 27, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants