Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: npm-update-20220714 to main #33

Merged
merged 2 commits into from
Jul 21, 2022
Merged

merge: npm-update-20220714 to main #33

merged 2 commits into from
Jul 21, 2022

Conversation

simplesense-bot
Copy link
Contributor

@mountainraptor @nanpx @psevery @sweigle88 @whitmer12 there were major changes when trying to update NPM dependencies. Please review and merge once approved.

  • update eslint-plugin-unicorn from ^42.0.0 to ^43.0.1 in package.json

package.json
  - update eslint-plugin-unicorn from ^42.0.0 to ^43.0.1
  - update eslint-plugin-vue from ^9.1.1 to ^9.2.0
  - update eslint from ^8.18.0 to ^8.19.0
  - update jest from ^28.1.1 to ^28.1.2
@simplesense-bot
Copy link
Contributor Author

simplesense-bot commented Jul 13, 2022

Test Coverage Report

Type npm-update-20220714 main Diff
lines 100% 100% 🟢 0%
statements 100% 100% 🟢 0%
functions 100% 100% 🟢 0%
branches 100% 100% 🟢 0%
branchesTrue 100% 100% 🟢 0%

@nanpx
Copy link
Contributor

nanpx commented Jul 13, 2022

@simplesenseio/tools-review I've disabled the unicorn/prefer-node-protocol rule because they no longer skip checking require imports.

It's harmless to keep it enabled and will autofix statements to use node:. For example, const fs = require('fs') becomes const fs = require('node:fs'). This isn't too important with common js, but as we start to port everything over to pure ESM, we'll want this rule active. If I keep this active, it means all our repos will need to have lint fixes applied, unfortunately there's no way to configure to rule to ignore require and apply to import.

Any preference on how to proceed?

  1. Keep the rule, all our repos will need a lint commit or have lint changes with their next commit
  2. Disable the rule and apply it when we start rewriting our node as ESM

@psevery
Copy link
Contributor

psevery commented Jul 13, 2022

@simplesenseio/tools-review I personally think either is fine. Disabling it seems like the easy button though.

@nanpx nanpx merged commit 0f024ca into main Jul 21, 2022
@nanpx nanpx deleted the npm-update-20220714 branch July 21, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants