Use Optimized Number Check

sinclairzx81 · Apr 27, 2024 · fb3e28c · fb3e28c
1 parent 1ba927c
commit fb3e28c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/compiler/compiler.ts b/src/compiler/compiler.ts
@@ -210,7 +210,7 @@ export namespace Policy {
       : `(typeof ${value} === 'object' && ${value} !== null && !(${value} instanceof Date) && !(${value} instanceof Uint8Array))`
   }
   export function IsNumberLike(value: string): string {
-    return !TypeSystemPolicy.AllowNaN ? `(typeof ${value} === 'number' && Number.isFinite(${value}))` : `typeof ${value} === 'number'`
+    return TypeSystemPolicy.AllowNaN ? `typeof ${value} === 'number'` : `Number.isFinite(${value})`
   }
   export function IsVoidLike(value: string): string {
     return TypeSystemPolicy.AllowNullVoid ? `(${value} === undefined || ${value} === null)` : `${value} === undefined`
@@ -288,7 +288,7 @@ export namespace TypeCompiler {
     yield `(typeof ${value} === 'function')`
   }
   function* FromInteger(schema: TInteger, references: TSchema[], value: string): IterableIterator<string> {
-    yield `(typeof ${value} === 'number' && Number.isInteger(${value}))`
+    yield `Number.isInteger(${value})`
     if (IsNumber(schema.exclusiveMaximum)) yield `${value} < ${schema.exclusiveMaximum}`
     if (IsNumber(schema.exclusiveMinimum)) yield `${value} > ${schema.exclusiveMinimum}`
     if (IsNumber(schema.maximum)) yield `${value} <= ${schema.maximum}`

diff --git a/src/system/policy.ts b/src/system/policy.ts
@@ -56,8 +56,7 @@ export namespace TypeSystemPolicy {
   }
   /** Asserts this value using the AllowNaN policy */
   export function IsNumberLike(value: unknown): value is number {
-    const isNumber = IsNumber(value)
-    return AllowNaN ? isNumber : isNumber && Number.isFinite(value)
+    return AllowNaN ? IsNumber(value) : Number.isFinite(value)
   }
   /** Asserts this value using the AllowVoidNull policy */
   export function IsVoidLike(value: unknown): value is void {

diff --git a/src/value/guard/guard.ts b/src/value/guard/guard.ts
@@ -171,7 +171,7 @@ export function IsNumber(value: unknown): value is number {
 }
 /** Returns true if this value is an integer */
 export function IsInteger(value: unknown): value is number {
-  return IsNumber(value) && Number.isInteger(value)
+  return Number.isInteger(value)
 }
 /** Returns true if this value is bigint */
 export function IsBigInt(value: unknown): value is bigint {