Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre-commit config #156

Closed
wants to merge 2 commits into from
Closed

Conversation

guykisel
Copy link

This PR is intended to implement #154 based on the docs at https://pre-commit.com/#new-hooks

It's not quite working but I think perhaps I am just missing something simple.

How I'm testing:

  1. I've cloned https://github.com/sindresorhus/awesome locally.
  2. I run pre-commit try-repo local\path\to\awesome-lint
  3. pre-commit installs awesome-lint and runs it and fails with Invalid GitHub repo URL: local\path\to\awesome\readme.md

However, I can repro this same issue when just directly running awesome-lint locally on awesome:

PS local\path\to\awesome> npx awesome-lint
Need to install the following packages:
  awesome-lint@0.18.1
Ok to proceed? (y) y
✖ Invalid GitHub repo URL: local\path\to\awesome\readme.md

I think I'm hitting this bit of code: https://github.com/sindresorhus/awesome-lint/blob/main/index.js#L65-L68 - and it thinks my local path is a url? Might just be an issue with Windows or PowerShell. 🤔

@sindresorhus
Copy link
Owner

Closing as this is not moving forward and it's not something I need or have time to dig into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants