Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not recursively camelCase keys in nested objects when using union with null #119

Merged
merged 2 commits into from Oct 18, 2023

Conversation

yutak23
Copy link
Contributor

@yutak23 yutak23 commented Oct 18, 2023

This ought to fix #118.

The bug in the issue is due to the fact that the type ObjectOptional assumed only undefined (optional property), so I have fixed that part.

Supplemental information on testing

Since the type CamelCaseKeys cannot be tested as is, it is tested by specifying the type CamelCaseKeys for the variable after conversion with camelcaseKeys.

The test for index.d.ts before the modification failed as follows, but after the modification, the test passes because the union part works correctly.

image

@sindresorhus sindresorhus merged commit 919a29e into sindresorhus:main Oct 18, 2023
3 checks passed
@yutak23 yutak23 deleted the feature/fix-union branch October 18, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 9 does not recursively camelCase keys in nested objects when using union with null
2 participants