fix: update type for input and optiopns and update README #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
yutak23
commented
Jan 12, 2024
| expectType<string[]>(camelcaseKeys(['name 1', 'name 2'])); | ||
|
|
||
| expectType<string[]>(camelcaseKeys(['name 1', 'name 2'], {deep: true})); | ||
|
|
There was a problem hiding this comment.
I have removed the unsupported array format test.
yutak23
force-pushed
the
feature/docs-update
branch
from
bcdab0c
to
b252ed7
Compare
yutak23
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue #121.
I am updating the README to match the TypeScript type definitions.
Note Regarding the existing type definitions, I don't see any problem with the existing type definitions. This is because the
map-objfunctionality thatcamelcase-keysrelies on appears to be intended to convert key-value record types, not object types.